Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added UI for ActionMenu and Settings panel. #2370

Merged
merged 6 commits into from
Feb 17, 2022

Conversation

TheoTheDev
Copy link
Contributor

@TheoTheDev TheoTheDev commented Feb 16, 2022

  • Core UI added.
  • All settings are saved/loaded.
  • Only 'Character details' gfx settings are actually applied.

image

image

image

image

image

Known issue: when changing 'Character details' lower -> higher it creates multiple levels of avatar in the scene.

- Core UI added.
- All settings are saved/loaded.
- Only 'Character details' gfx settings are actually applied.
@avaer
Copy link
Contributor

avaer commented Feb 16, 2022

The settings panel looks cool, but can we clean up those top-right buttons? There are too many styles going on there IMO. It could be the simple boxes for now.

@avaer
Copy link
Contributor

avaer commented Feb 16, 2022

Looks like it has different font size. Other than that, looks good.

@amnaarshed4224 can you check it out?

@alisaad673
Copy link
Contributor

alisaad673 commented Feb 17, 2022

Some issues that can be addressed right now are:
1-The font size of new components(Settings, Mode ) seems different as compared to the already existing ones(World, Login, Character tab).
2-The new components do not get highlighted when curser is over them. They should get highlighted like the already existing ones.

highlight

3-The hotbar UI is previous one, as avaer asked to use the already existing one.

items panel

4-Once we are inside settings panel, clicking anywhere makes the curser go into the game, We need to press "Esc" to get cursor back. It should be disabled.(Sorry, for some reason cursor isnt appearing in the screen recording.)

bandicam.2022-02-17.20-48-14-949.mp4

- Fixed styles for ActionMenu [font-size, hover, etc].
- Stopped PointerCapture when clicking somewhere in SettingsMenu.
- Merged with latest master.
@TheoTheDev
Copy link
Contributor Author

TheoTheDev commented Feb 17, 2022

@amnaarshed4224 All requested changes done.

image

[VR btn text size a bit smaller, cause will take too much place on the screen cause of text length]

@alisaad673
Copy link
Contributor

alisaad673 commented Feb 17, 2022

hey, I have pulled the totum, its working fine with master, But not with this repo.
I am getting this error again, even though i have pulled the totum and its up to date.

tyui

totum

@avaer can you please help?

@avaer
Copy link
Contributor

avaer commented Feb 17, 2022

This PR updates totum for some reason. Bad merge? It would cause the above error.

@avaer
Copy link
Contributor

avaer commented Feb 17, 2022

@avaer
Copy link
Contributor

avaer commented Feb 17, 2022

The merge was fixed with ede1867.

@TheoTheDev
Copy link
Contributor Author

Synced with master again and removed unneeded image.
image
No issue on my side [latest master merged, lates totum pulled].

@avaer
Copy link
Contributor

avaer commented Feb 17, 2022

The font size is still not the same for all of the buttons.

image

Edit: n/m, this was addressed in the footnote:

[VR btn text size a bit smaller, cause will take too much place on the screen cause of text length]

And that makes sense to me.

@avaer avaer merged commit 339d51d into master Feb 17, 2022
@TheoTheDev TheoTheDev deleted the ui/top-left-menu-and-settings branch April 22, 2022 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants