Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance settings persistence #2321

Open
avaer opened this issue Feb 5, 2022 · 2 comments
Open

Performance settings persistence #2321

avaer opened this issue Feb 5, 2022 · 2 comments
Assignees

Comments

@avaer
Copy link
Contributor

avaer commented Feb 5, 2022

We have an avatar auto-optimization pipeline coming online, and it can be tested in the options panel. (Ignore the UI)

image

We want to make this setting persistent, auto-detected, and applied to all avatars in the scene, for UX/performance reasons.

Requirements

  1. Make the avatar setting persistent across reloads (apply directly on load, without the unoptimized avatar ever being rendered). Can use localStorage to store the setting
  2. Make the setting apply to all avatars in the scene (all totum VRM)
  3. Bugfix corner cases, like the dioramas not rendering
  4. Support some sort of heuristic for setting the performance mode if it was not previously set, or at least don't always use the MToon HQ mode, since that is a performance killer -- one option is we default to the crunched avatar in all cases
  5. (Performance optimization) use the crunched version of the avatar for depth rendering in the post processing stack, and the diorama, to collapse draw calls into one
@avaer
Copy link
Contributor Author

avaer commented Feb 7, 2022

This seems like a good library to use for calibration:

https://github.com/pmndrs/detect-gpu
https://pmndrs.github.io/detect-gpu/

It is framerate-uncapped, and the determined FPS can be used to get a ballpark figure on the spec of the machine, which is bucketed into slots.

@avaer avaer changed the title Persistent avatar settings Performance settings persistence Feb 7, 2022
@0reo 0reo self-assigned this Mar 11, 2022
@0reo
Copy link
Contributor

0reo commented Mar 11, 2022

@0reo 0reo added this to the Avatar Quality Settings milestone Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants