Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hpanel accurate info with draw calls #2335

Merged
merged 2 commits into from
Feb 9, 2022
Merged

Hpanel accurate info with draw calls #2335

merged 2 commits into from
Feb 9, 2022

Conversation

Sirahi
Copy link
Contributor

@Sirahi Sirahi commented Feb 8, 2022 •
edited by sync-by-unito bot
Loading

No description provided.

@Sirahi Sirahi requested a review from avaer February 8, 2022 21:43
This was linked to issues Feb 8, 2022
H panel: inaccurate #2285
Open
Delete stats panel #2313
Closed
@avaer
Copy link
Contributor

avaer commented Feb 9, 2022

From the author, since the PR is missing a description:

I figured out the issue. I was calling info reset in the stats which only gets called when h panel is open since you added the check game.debugMode in render loop. So when h panel was off, not resetting info was causing rendering issues

avaer
avaer approved these changes Feb 9, 2022
View reviewed changes
Copy link
Contributor

@avaer avaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more try at fixing the bug. Thanks @Sirahi!

@avaer avaer merged commit 64ab705 into master Feb 9, 2022
@avaer
Copy link
Contributor

avaer commented Feb 10, 2022

I think this is causing errors again and needs to be reverted.

image

@avaer
Copy link
Contributor

avaer commented Feb 10, 2022

This was reverted again.

This was referenced Feb 10, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avaer avaer avaer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

H panel: inaccurate Delete stats panel
2 participants
@Sirahi @avaer