Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete stats panel #2313

Closed
avaer opened this issue Feb 2, 2022 · 4 comments · Fixed by #2335
Closed

Delete stats panel #2313

avaer opened this issue Feb 2, 2022 · 4 comments · Fixed by #2335

Comments

@avaer
Copy link
Contributor

avaer commented Feb 2, 2022 •
edited
Loading

I think we should just delete the stats panel entirely for now.

Right now it is providing inaccurate info, nobody understands the way the stats work, and multiple PRs have failed to fix it.
@avaer
Copy link
Contributor Author

avaer commented Feb 2, 2022 •
edited
Loading

This can hopefully be replaced by a solution that is not based on copy pasted THREE.js stats, which seems incompatible with custom render stacks.

@Sirahi
Copy link
Contributor

Sirahi commented Feb 8, 2022

I fixed it. It was a small issue of not calling the info reset at the right place due to which my PR failed.

@Sirahi Sirahi linked a pull request Feb 8, 2022 that will close this issue
Hpanel accurate info with draw calls #2335
Merged
@avaer avaer reopened this Feb 10, 2022
@avaer
Copy link
Contributor Author

avaer commented Feb 10, 2022

#2335 was reverted due to bugs.

@TheoTheDev
Copy link
Contributor

Will just use this one #2285
as one issue and close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Hpanel accurate info with draw calls webaverse/app
3 participants
@TheoTheDev @avaer @Sirahi