Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4.0.1-alpha.2 #5664

Merged
merged 5 commits into from
Dec 8, 2022
Merged

v4.0.1-alpha.2 #5664

merged 5 commits into from
Dec 8, 2022

Conversation

spacesailor24
Copy link
Contributor

@spacesailor24 spacesailor24 commented Nov 30, 2022

Added

web3-eth-contract

web3-types

web3-utils

web3-eth-contract

Fixed

web3-eth-contract

web3-types

web3-utils

web3-validator

web3-eth-abi

  • Fix ContractMethodOutputParameters type to support output object types by index and string key. Also, it returns void if ABI doesn't have outputs and returns exactly one type if the output array has only one element. (Documentation for catching provider events #5631)

Removed

web3-eth-accounts

@render
Copy link

render bot commented Nov 30, 2022

@spacesailor24 spacesailor24 requested a review from avkos November 30, 2022 00:18
* Update CHANGELOG version headers

* Update CHANGELOGs

* Revert package version bump for web3-packagetemplate
@spacesailor24 spacesailor24 marked this pull request as ready for review December 6, 2022 17:56
@avkos
Copy link
Contributor

avkos commented Dec 6, 2022

@spacesailor24 thanks for PR. just need to merge 4.x into this branch and resolve conflicts.

@spacesailor24
Copy link
Contributor Author

@spacesailor24 thanks for PR. just need to merge 4.x into this branch and resolve conflicts.

@avkos So usually we would have an RC version we could bump every time we make changes to the release since the last commit in the release is tagged with the version. We've already messed up by merging #5689 into this branch, since now the branch has commits that come after the tagged commit. This isn't a huge issue since this only really affects the continuity of the release listed in Github (I'm talking about the Assets listed in the release). I believe the right steps would've been to open a PR that merges 4.x into the release branch to solve the conflicts and cut another RC, but we don't have that option now since there are no RC versions for 4.x yet

So, if we are to merge 4.x into the release branch and solve the conflicts, we'd need to re-build all the packages, commit, tag the commit, and re-create the release on Github

@jdevcs
Copy link
Contributor

jdevcs commented Dec 7, 2022

@spacesailor24 thanks for PR. just need to merge 4.x into this branch and resolve conflicts.

@avkos So usually we would have an RC version we could bump every time we make changes to the release since the last commit in the release is tagged with the version. We've already messed up by merging #5689 into this branch, since now the branch has commits that come after the tagged commit. This isn't a huge issue since this only really affects the continuity of the release listed in Github (I'm talking about the Assets listed in the release). I believe the right steps would've been to open a PR that merges 4.x into the release branch to solve the conflicts and cut another RC, but we don't have that option now since there are no RC versions for 4.x yet

So, if we are to merge 4.x into the release branch and solve the conflicts, we'd need to re-build all the packages, commit, tag the commit, and re-create the release on Github

In case of merge conflicts, and before actual release, could you go ahead with following:
Merge main branch into release PR, build, delete old tag, recreate new tag, and re populate github draft release with newly created tag. There isn't any technical limitation or issue in that, if it happens before release on npm / github.

In future we should also follow freezing main branch for 4.x if there is release PR created, we were following this in 1.x.

spacesailor24 and others added 2 commits December 8, 2022 10:00
* Update CHANGELOG version headers

* Contract call with tuple is missing param names (#5613)

* call special output type

* fix

* fix: enable outputs to have param names (#5624)

* hot fix

* add type if only one param

* overloaded inputs types

* fix resolver tests

* add type tests

* simplify types

* revert registry unit test

* test firefox

* revert firefox test

* update changelogs

Co-authored-by: Marin Petrunić <[email protected]>

* Fix `isHex` and `isHexStrict` for some edge cases and enrich their tests (#5655)

* Change `isHex` to return true for negative numbers (for example `-123`)
* Change both `isHex` and `isHexStrict` to return `false` for `-0x`
* Change `isHex` to return `false` for empty strings ''.

* Remove erroneous set provider code for Contract constructor (#5669)

* Remove erroneous set provider code for Contract constructor. Add Contract constructor provider set test

* Update CHANGELOGs

* Debugging failing integration tests

* Apply suggestions from code review

* Use getSystemTestProvider instead of hardcoded string

* Refactor ternaries in Contract constructor to if statements

* Correct CHANGELOG entries

* Remove unneeded checks in if statements

* Test with injected external providers (#5652)

* fix: sending tx with injected provider (#5651)

Co-authored-by: Marin Petrunic <[email protected]>

* adding a test for using `ganache` provider

* enable the jsonrpc `id` to optionally be incremented starting from a number
 (Inspired by: #5373 (comment) and needed as a work around for blockchainsllc/in3#46)

* test with `in3` as a provider & skip `in3` test if it takes too long

* increase integration test timeout at web3 package

* add a test for using `hardhat` provider

* improve how legacy providers, such as hardhat, is used

* implement `isPromise` that works in the browsers

* refactor external providers tests

* update CHANGELOG.md

* Use Error ABI to parse errors when sending a transaction (#5662)

* use Error ABI when sending a transaction

* update CHANGELOG.md for #5587

* Remove merge conflict marker

Co-authored-by: Oleksii Kosynskyi <[email protected]>
Co-authored-by: Marin Petrunić <[email protected]>
Co-authored-by: Muhammad Altabba <[email protected]>
Co-authored-by: jdevcs <[email protected]>
* Update CHANGELOG version headers

* Remove merge conflict markers

* Remove double CHANGELOG entry
@spacesailor24 spacesailor24 merged commit 6c166b9 into 4.x Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x 4.0 related Release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants