-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update wallet.encrypt function signature 4.x #5581
Merged
avkos
merged 12 commits into
4.x
from
ok/5188-Update-Wallet.encrypt-function-signature---4.x
Nov 9, 2022
Merged
Update wallet.encrypt function signature 4.x #5581
avkos
merged 12 commits into
4.x
from
ok/5188-Update-Wallet.encrypt-function-signature---4.x
Nov 9, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avkos
requested review from
luu-alex,
jdevcs,
Muhammad-Altabba,
nikoulai and
spacesailor24
November 3, 2022 00:51
luu-alex
reviewed
Nov 3, 2022
luu-alex
approved these changes
Nov 3, 2022
Looks good 👍 |
jdevcs
reviewed
Nov 7, 2022
Your Render PR Server URL is https://atweb3js-docs-pr-5581.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cdkqubda4996o5i1c3a0. |
jdevcs
reviewed
Nov 8, 2022
jdevcs
reviewed
Nov 8, 2022
jdevcs
reviewed
Nov 8, 2022
Co-authored-by: Junaid <[email protected]>
Co-authored-by: Junaid <[email protected]>
Co-authored-by: Junaid <[email protected]>
jdevcs
approved these changes
Nov 9, 2022
avkos
deleted the
ok/5188-Update-Wallet.encrypt-function-signature---4.x
branch
November 9, 2022 19:07
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5188
Type of change
Checklist for 4.x:
yarn
successfullyyarn lint
successfullyyarn build:web
successfullyyarn test:unit
successfullyyarn test:integration
successfullycompile:contracts
successfullyCHANGELOG.md
file in the packages I have edited.