-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use BigInt when decoding functions' and events' parameters returned from Smart Contracts calls and events #5435
Merged
Muhammad-Altabba
merged 14 commits into
4.x
from
fix/5431/use-BigInt-when-returning-the-encoded-function-parameters
Sep 16, 2022
Merged
Use BigInt when decoding functions' and events' parameters returned from Smart Contracts calls and events #5435
Muhammad-Altabba
merged 14 commits into
4.x
from
fix/5431/use-BigInt-when-returning-the-encoded-function-parameters
Sep 16, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your Render PR Server URL is https://web3js-docs-pr-5435.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-ccgfqd6n6mptaa6besg0. |
Muhammad-Altabba
changed the title
use BigInt when returning the encoded function parameters
Use BigInt when returning the encoded function parameters
Sep 13, 2022
jdevcs
requested changes
Sep 15, 2022
Muhammad-Altabba
requested review from
nikoulai,
avkos,
jdevcs,
luu-alex and
spacesailor24
September 15, 2022 12:51
jdevcs
reviewed
Sep 15, 2022
jdevcs
approved these changes
Sep 15, 2022
spacesailor24
approved these changes
Sep 16, 2022
…d-function-parameters
Muhammad-Altabba
changed the title
Use BigInt when returning the encoded function parameters
Use BigInt when decoding functions' and events' parameters
Sep 16, 2022
Muhammad-Altabba
changed the title
Use BigInt when decoding functions' and events' parameters
Use BigInt when decoding functions' and events' parameters returned from Smart Contracts calls and events
Sep 16, 2022
Muhammad-Altabba
deleted the
fix/5431/use-BigInt-when-returning-the-encoded-function-parameters
branch
September 16, 2022 04:58
2 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #(issue)
I also added
innerError
as optional property insideWeb3Errro
.Type of change
Checklist for 1.x:
npm run dtslint
with success and extended the tests and types if necessary.npm run test:cov
and my test cases cover all the lines and branches of the added code.npm run build
with success.dist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.Checklist for 4.x:
yarn
successfullyyarn lint
successfullyyarn build:web
successfullyyarn test:unit
successfullyyarn test:integration
successfullycompile:contracts
successfullyCHANGELOG.md
file in the packages I have edited.