Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String is used instead of BigInt when returning the encoded function parameters #5431

Closed
1 task done
Muhammad-Altabba opened this issue Sep 13, 2022 · 0 comments
Closed
1 task done
Assignees
Labels
4.x 4.0 related Bug Addressing a bug

Comments

@Muhammad-Altabba
Copy link
Contributor

Muhammad-Altabba commented Sep 13, 2022

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

I think it was planned for 4.x to use BigInt when decoding values.

However, as in this test case, for example, the value return is a string:
https://github.com/ChainSafe/web3.js/blob/7e236d0b3913c08049f4fafd13e1923ee941b2d2/packages/web3-eth-contract/test/integration/contract_methods.test.ts#L49

Steps to Reproduce

Change '10' in the following line to 10n and then run the test:
https://github.com/ChainSafe/web3.js/blob/7e236d0b3913c08049f4fafd13e1923ee941b2d2/packages/web3-eth-contract/test/integration/contract_methods.test.ts#L49

Web3.js Version

4.x

Environment

No response

Anything Else?

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x 4.0 related Bug Addressing a bug
Projects
None yet
Development

No branches or pull requests

1 participant