Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to wokring version of geth-dev-assistant #3693

Merged
merged 1 commit into from
Aug 18, 2020

Conversation

GregTheGreek
Copy link
Contributor

Description

This supersedes #3690 as it uses an updated version of geth-dev-assistant that is able to use the latest docker version of go-ethereum rather than a tagged version.

Closes #3687

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.001%) to 84.342% when pulling ed698d5 on greg/ci-investigate into 0151821 on 1.x.

@GregTheGreek GregTheGreek merged commit 3ca39a7 into 1.x Aug 18, 2020
@GregTheGreek GregTheGreek deleted the greg/ci-investigate branch August 18, 2020 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI Failures
3 participants