Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin geth docker version to v1.9.18 #3690

Closed
wants to merge 1 commit into from
Closed

Pin geth docker version to v1.9.18 #3690

wants to merge 1 commit into from

Conversation

ryanio
Copy link
Collaborator

@ryanio ryanio commented Aug 17, 2020

Description

Currently ci is failing in trying to set up a geth instance for the e2e tests.

This PR tests pinning the geth version for geth-dev-assistant to 1.9.18 to see if the issue is something in the latest 1.9.19 release.

E2E: geth insta-mining (requires docker) 
>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>
 
> Pulling ethereum/client-go:stable
> ⚠️  Launching ethereum/client-go:stable as a background process. ⚠️ 
> ⚠️  Run docker stop geth-client when you are finished testing.   ⚠️
> Waiting for geth to launch... (10 sec maximum).
> Timed out while waiting for geth to launch.
  + Use --sleep <sec> to increase the wait time.
  + Use --interactive to see any errors geth may be throwing.

geth-client
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! web3.js@ test:e2e:geth:insta: `./scripts/e2e.geth.instamine.sh`
npm ERR! Exit status 1

Type of change=

  • ci fix

@ryanio ryanio added the CI label Aug 17, 2020
@ryanio ryanio changed the title pin e2e geth version to 1.9.18 Pin geth docker version to v1.9.18 Aug 17, 2020
@coveralls
Copy link

Coverage Status

Coverage remained the same at 85.343% when pulling 13a3faf on pin-geth-1.9.18 into 0151821 on 1.x.

@ryanio
Copy link
Collaborator Author

ryanio commented Aug 17, 2020

Running geth-dev-assistant with --interactive outputs:

npx geth-dev-assistant --accounts 1 --tag 'stable' --interactive
> Pulling ethereum/client-go:stable
> ⚠️  Launching ethereum/client-go:stable as a background process. ⚠️
> ⚠️  Run docker stop geth-client when you are finished testing.   ⚠️
> Waiting for geth to launch... (10 sec maximum).

Geth reported error: INFO [08-17|17:38:55.025] Starting Geth in ephemeral dev mode...

So it must be getting confused that "Starting Geth in ephemeral dev mode..." message is coming through stderr, but according to https://github.com/cgewecke/geth-dev-assistant/blob/master/lib/app.js#L40-L51 if run without the --interactive flag, it shouldn't exit the process, so not exactly sure.

Copy link
Contributor

@GregTheGreek GregTheGreek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM until we update the upstream repo. I've found the probable cause, and looking at a patch. May need to fork if @cgewecke isn't around to merge it.

@ryanio ryanio closed this Aug 18, 2020
@mpetrunic mpetrunic deleted the pin-geth-1.9.18 branch October 31, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants