Update the css-properties-values-api IDL file #9774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukebjerring
force-pushed
the
idl-file-updates-css-properties-values-api
branch
from
cb087b1 to
1182b47
Compare
Build ERROREDStarted: 2018-03-08 00:11:30 Failing Jobs
View more information about this build on: |
lukebjerring
force-pushed
the
idl-file-updates-css-properties-values-api
branch
from
1182b47 to
30997d1
Compare
lukebjerring
requested review from
foolip
and removed request for
jensl and
yuki3
foolip
requested changes
Jul 16, 2018
| dictionary PropertyDescriptor { | ||
| required DOMString name; | ||
| DOMString syntax = "*"; | ||
| boolean inherits = false; |
There was a problem hiding this comment.
@lukebjerring this is out of sync with the spec, can you update this PR?
lukebjerring
force-pushed
the
idl-file-updates-css-properties-values-api
branch
from
9dac8c2 to
6dd530c
Compare
|
Updated. PTAL. |
|
Note that we'll have an unimportant failure for the partial CSS namespace until #11819 lands. |
foolip
approved these changes
Jul 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello reviewer(s),
This PR is intended to consolidate the spec’s IDL definition with the WPT test suite’s copy, and any idlharness tests.
The up-to-date copy of the IDL file was automatically extracted from the reffy-reports repo (https://github.com/tidoust/reffy-reports/tree/master/whatwg/idl) which scrapes known specs automatically + regulary.
This PR is part of a migration project which will eventually be automatically updating and creating PRs for changes in spec IDL.
Please check that:
The Spec (and its source) is correct and up-to-date
All tests which cover the IDL in the spec have been migrated to fetch + use the idl in the
interfaces/directory (instead of inline copies in the test files).