-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the cssom IDL file #11819
Update the cssom IDL file #11819
Conversation
|
bd4cd7c
to
5ab5fbb
Compare
This is now ready for review. |
Tried the changes locally and it looks good, there are slightly fewer tests but it seems to be because tests like "Unscopable handled correctly for escape(CSSOMString) on CSS" no longer exist. ("CSS namespace: operation escape(CSSOMString)" does.) The number of failing tests is the same. I expected the switch from Also updated some specs: @lukebjerring, do you think we should just merge this and let the IDL files be in an inconsistent state for a while as long as it doesn't break things, or line up a bunch of PRs and merge them at once? |
Probably a good idea for this to update all of the |
The two spec PRs have landed. w3c/css-houdini-drafts#784 has propagated to reffy in w3c/webref@ee634c9 but WICG/css-parser-api#12 will need @tabatkins to regenerate index.html first. |
Regenerated CSS-Parser-API |
Cool, in 24 hours or so https://github.com/tidoust/reffy-reports/blob/master/whatwg/idl/CSS-Parser-API.idl ought to be updated. |
5ab5fbb
to
2137978
Compare
Tested locally, it works! |
Hello reviewer(s),
This PR is intended to consolidate the spec’s IDL definition with the WPT test suite’s copy, and any idlharness tests.
The up-to-date copy of the IDL file was automatically extracted from the reffy-reports repo (https://github.com/tidoust/reffy-reports/tree/master/whatwg/idl) which scrapes known specs automatically + regulary.
This PR is part of a migration project which will eventually be automatically updating and creating PRs for changes in spec IDL.
Please check that:
The spec (and its source) is correct and up-to-date
All tests which cover the IDL in the spec have been migrated to fetch + use the idl in the
interfaces/
directory (instead of inline copies in the test files).