Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the cssom IDL file #11819

Merged
merged 3 commits into from
Jul 31, 2018

Conversation

lukebjerring
Copy link
Contributor

Hello reviewer(s),

This PR is intended to consolidate the spec’s IDL definition with the WPT test suite’s copy, and any idlharness tests.

The up-to-date copy of the IDL file was automatically extracted from the reffy-reports repo (https://github.com/tidoust/reffy-reports/tree/master/whatwg/idl) which scrapes known specs automatically + regulary.

This PR is part of a migration project which will eventually be automatically updating and creating PRs for changes in spec IDL.

Please check that:
The spec (and its source) is correct and up-to-date
All tests which cover the IDL in the spec have been migrated to fetch + use the idl in the interfaces/ directory (instead of inline copies in the test files).

@lukebjerring
Copy link
Contributor Author

lukebjerring commented Jul 6, 2018

Note that the namespace chunk is manually commented out, as it's blocked by #7583

@lukebjerring lukebjerring force-pushed the idl-file-updates-cssom branch from bd4cd7c to 5ab5fbb Compare July 18, 2018 14:20
@lukebjerring lukebjerring requested a review from Ms2ger July 18, 2018 14:20
@lukebjerring
Copy link
Contributor Author

This is now ready for review.

@foolip
Copy link
Member

foolip commented Jul 21, 2018

Tried the changes locally and it looks good, there are slightly fewer tests but it seems to be because tests like "Unscopable handled correctly for escape(CSSOMString) on CSS" no longer exist. ("CSS namespace: operation escape(CSSOMString)" does.) The number of failing tests is the same.

I expected the switch from interface CSS to namespace CSS to break other tests because css-conditional.idl and css-paint-api.idl still have partial interface CSS, but that didn't happen for either test, the test names just changed and still work. Filed: #12123

Also updated some specs:
w3c/css-houdini-drafts#784
WICG/css-parser-api#12

@lukebjerring, do you think we should just merge this and let the IDL files be in an inconsistent state for a while as long as it doesn't break things, or line up a bunch of PRs and merge them at once?

@lukebjerring
Copy link
Contributor Author

Probably a good idea for this to update all of the partial namespace defs at the same time.

@foolip
Copy link
Member

foolip commented Jul 27, 2018

The two spec PRs have landed. w3c/css-houdini-drafts#784 has propagated to reffy in w3c/webref@ee634c9 but WICG/css-parser-api#12 will need @tabatkins to regenerate index.html first.

@tabatkins
Copy link
Contributor

Regenerated CSS-Parser-API

@foolip
Copy link
Member

foolip commented Jul 27, 2018

Cool, in 24 hours or so https://github.com/tidoust/reffy-reports/blob/master/whatwg/idl/CSS-Parser-API.idl ought to be updated.

@lukebjerring lukebjerring force-pushed the idl-file-updates-cssom branch from 5ab5fbb to 2137978 Compare July 31, 2018 08:16
@foolip
Copy link
Member

foolip commented Jul 31, 2018

Tested locally, it works!

@foolip foolip merged commit 8b48137 into web-platform-tests:master Jul 31, 2018
@lukebjerring lukebjerring deleted the idl-file-updates-cssom branch October 5, 2018 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants