Add TrustedType tests for iframe.srcdoc. #49996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems we already have some tests for iframe.srcdoc but things are a bit messy so it's unclear whether we cover blocking, conversion check and sink names (#494) and null string edge case. Add a simple test doing that, similar to other `block-string-assignment-to-*` tests.
lukewarlow
requested changes
Jan 9, 2025
trusted-types/block-string-assignment-to-HTMLIFrameElement-srcdoc.html
Outdated
Show resolved
Hide resolved
lukewarlow
approved these changes
Jan 9, 2025
Yes, I verified the latest version in Chromium, Safari and Firefox. |
fred-wang
deleted the
block-string-assignment-to-HTMLIFrameElement-srcdoc
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems we already have some tests for iframe.srcdoc but things are a bit messy so it's unclear whether we cover blocking, conversion check and sink names (#494) and null string edge case. Add a simple test doing that, similar to other
block-string-assignment-to-*tests.