MS tests on audio element #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
deniak
commented
Jan 6, 2014
deniak
commented
- audio_001* and audio_002* already moved in /html/semantics/embedded-content-0/the-audio-element
- audio_004 and audio_005 already covered by /html/semantics/embedded-content-0/the-audio-element/audio_attributes.html
- fix audio_003
- audio_001* and audio_002* already moved in /html/semantics/embedded-content-0/the-audio-element - audio_004 and audio_005 already covered by /html/semantics/embedded-content-0/the-audio-element/audio_attributes.html - fix audio_003
|
Critic review: https://critic.hoppipolla.co.uk/r/525 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
split audio_003 into 1 testharness and 1 reftest
rm duplicates tests refactoring
rm trailing ws
fred-wang
added a commit
that referenced
this pull request
Jan 9, 2025
It seems we already have some tests for iframe.srcdoc but things are a bit messy so it's unclear whether we cover blocking, conversion check and sink names (#494) and null string edge case. Add a simple test doing that, similar to other `block-string-assignment-to-*` tests.
fred-wang
added a commit
that referenced
this pull request
Jan 9, 2025
* Add TrustedType tests for iframe.srcdoc. It seems we already have some tests for iframe.srcdoc but things are a bit messy so it's unclear whether we cover blocking, conversion check and sink names (#494) and null string edge case. Add a simple test doing that, similar to other `block-string-assignment-to-*` tests. * fix many errors
sadym-chromium
pushed a commit
that referenced
this pull request
Jan 14, 2025
* Add TrustedType tests for iframe.srcdoc. It seems we already have some tests for iframe.srcdoc but things are a bit messy so it's unclear whether we cover blocking, conversion check and sink names (#494) and null string edge case. Add a simple test doing that, similar to other `block-string-assignment-to-*` tests. * fix many errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.