Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update stereo opus test to expect upmixing. #49392

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Update stereo opus test to expect upmixing. #49392

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions webrtc/RTCRtpEncodingParameters-codec-opus-stereo.https.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,11 @@
const audio = document.createElement('audio');
audio.srcObject = new MediaStream();
audio.srcObject.addTrack(remoteTrack);
assert_equals(await pollChannelCount(t, remoteTrack), 1,
'Remote track is also mono');
}, 'Sending and receiving a mono track with opus');
// The stereo opus decoder outputs stereo regardless of the signal on the
// wire.
assert_equals(await pollChannelCount(t, remoteTrack), 2,
'Remote track is stereo (despite local track being mono)');
}, 'Sending and receiving a mono track with opus (stereo decoder upmix)');

promise_test(async t => {
const pc1 = new RTCPeerConnection();
Expand Down