Update stereo opus test to expect upmixing. #49392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the test that sends and receives a local mono track with opus that on the remote side the channelCount is 2 because the opus decoder performs upmixing. This strange behavior is option 1) discussed in w3c/webrtc-pc#3010. This allows for some optimization and simplifications which aids in virtual audio SSRC use case of flip-flopping between mono and stereo signals on the wire and not having to re-initialize the decoder (which could cause glitches). The vibe from the November Virtual Interim (https://www.w3.org/2024/11/19-webrtc-minutes.html#561c) was to standardize what libwebrtc does when stereo is enabled, and this is what it does. Note: We still fail the test today though because "stereo opus" has not been enabled-by-default. When it is the expectation is that we pass both of these tests. Bug: webrtc:379996136 Change-Id: Ibd6ee91a59d7c673bf53ad2302ba33f16b8b4ede Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6049355 Reviewed-by: Harald Alvestrand <[email protected]> Commit-Queue: Henrik Boström <[email protected]> Cr-Commit-Position: refs/heads/main@{#1388674}
wpt-pr-bot
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the test that sends and receives a local mono track with opus
that on the remote side the channelCount is 2 because the opus decoder
performs upmixing.
This strange behavior is option 1) discussed in
w3c/webrtc-pc#3010. This allows for some
optimization and simplifications which aids in virtual audio SSRC use
case of flip-flopping between mono and stereo signals on the wire and
not having to re-initialize the decoder (which could cause glitches).
The vibe from the November Virtual Interim
(https://www.w3.org/2024/11/19-webrtc-minutes.html#561c) was to
standardize what libwebrtc does when stereo is enabled, and this is
what it does.
Note: We still fail the test today though because "stereo opus" has not
been enabled-by-default. When it is the expectation is that we pass
both of these tests.
Bug: webrtc:379996136
Change-Id: Ibd6ee91a59d7c673bf53ad2302ba33f16b8b4ede
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6049355
Reviewed-by: Harald Alvestrand <[email protected]>
Commit-Queue: Henrik Boström <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1388674}