Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit win64 on 64bit Windows for chrome platform string #47686

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Emit win64 on 64bit Windows for chrome platform string #47686

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
069a7b1
Emit win64 on 64bit Windows for chrome platform string
saschanaz Aug 20, 2024
f4d1e1c
adjust test
saschanaz Aug 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tools/wpt/browser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -956,7 +956,7 @@ def _chrome_platform_string(self):
of the Chrome for Testing downloads.
"""
if self.platform in ("Linux", "Win"):
bits = "64" if uname.machine == "x86_64" else "32"
bits = "64" if uname.machine in ("x86_64", "AMD64") else "32"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Linux emits x86_64 while Windows emits AMD64 here. For future reference, for 64bit ARM processor Linux emits aarch64 while Windows emits ARM64)

elif self.platform == "Mac":
bits = "-arm64" if uname.machine == "arm64" else "-x64"
else:
Expand Down
Loading