Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit win64 on 64bit Windows for chrome platform string #47686

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

saschanaz
Copy link
Member

Skipping ARM64/aarch64 check as it seems it's not available yet.

@@ -956,7 +956,7 @@ def _chrome_platform_string(self):
of the Chrome for Testing downloads.
"""
if self.platform in ("Linux", "Win"):
bits = "64" if uname.machine == "x86_64" else "32"
bits = "64" if uname.machine in ("x86_64", "AMD64") else "32"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Linux emits x86_64 while Windows emits AMD64 here. For future reference, for 64bit ARM processor Linux emits aarch64 while Windows emits ARM64)

@saschanaz saschanaz enabled auto-merge (squash) August 29, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants