[webdriver] Enhance tests for implicitly accepting "beforeunload" prompts #44232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
AutomatedTester,
jgraham,
jrandolf-2,
juliandescottes,
sadym-chromium and
shs96c
whimboo
force-pushed
the
webdriver-beforeunload
branch
from
2886fe2 to
284d734
Compare
|
@sadym-chromium and @jgraham could you please review? Thanks. Note that tests for Chrome are failing because the dialog isn't correctly accepted by default. Nevertheless the tests are according to the current WebDriver classic specification. |
|
@nechaev-chromium PTAL |
nechaev-chromium
approved these changes
Jan 31, 2024
|
Given that only Chrome is failing to run these new tests and both Firefox and Safari work fine, I'm going to just merge this PR now that we got an approval. Thanks @nechaev-chromium! |
mbrodesser-Igalia
pushed a commit
to mbrodesser-Igalia/wpt
that referenced
this pull request
Feb 19, 2024
marcoscaceres
pushed a commit
that referenced
this pull request
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR I'm going to add a couple of user prompt tests specific to
beforeunloadprompts which are very poorly covered at the moment. These are important to have to see what the current cross-browser behavior is and how this feature could potentially co-work with WebDriver BiDi where we do not want to implicitly dismiss this kind of dialog by default.