-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WebDriver BiDi] Add tests for browsingContext.close
for promptUnload
#44004
Conversation
There are no reviewers for this pull request. Please reach out on the chat room to get help with this. Thank you! |
@Lightning00Blade is it expected to pass for the Chrome version in wpt.fyi? |
29a102c
to
12f2315
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing the remaining failures. It looks fine to me now. Just a small nit inline, but fine for landing anyway. Thank you as well for working on these tests!
Co-authored-by: Henrik Skupin <[email protected]>
Uh oh! Looks like an error!Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:
This request requires the client to satisfy the following scope expression:
|
Uh oh! Looks like an error!Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:
This request requires the client to satisfy the following scope expression:
|
Uh oh! Looks like an error!Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:
This request requires the client to satisfy the following scope expression:
|
Uh oh! Looks like an error!Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:
This request requires the client to satisfy the following scope expression:
|
Uh oh! Looks like an error!Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:
This request requires the client to satisfy the following scope expression:
|
@Lightning00Blade as it looks like Chrome is timing out on the |
@whimboo it's issue on our end, we can merge this as is. |
…oad` (#44004) * [WebDriver BiDi] Add tests for `browsingContext.close` for `promptUnload` * fix * chore: address comments * chore: add more tests * chore: add safe to prevent file timeouts * chore: listen if the event is emitted * chore: fix python * chore: simplify * chore: fix * Update webdriver/tests/bidi/browsing_context/close/prompt_unload.py Co-authored-by: Henrik Skupin <[email protected]> * chore: format --------- Co-authored-by: Henrik Skupin <[email protected]>
Add the scaffolding and test for
browsingContext.close
for parameterpromptUnload
.PR does not cover testing subframes that have
beforeunload
handlers (feature PR).