Change parentheses for css math functions serialization test #43513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Dec 5, 2023
Add parentheses around multiplication operation as per spec: https://drafts.csswg.org/css-values/#serialize-a-calculation-tree we should add parentheses around the product node. Github discussion: #43364 Change-Id: I7879bfc2cc62af63dd7598d380e10e96426ff5dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5087987 Reviewed-by: Anders Hartvoll Ruud <[email protected]> Commit-Queue: Daniil Sakhapov <[email protected]> Cr-Commit-Position: refs/heads/main@{#1233345}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5087987
branch
from
cf05624 to
859a407
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add parentheses around multiplication operation as per spec:
https://drafts.csswg.org/css-values/#serialize-a-calculation-tree
we should add parentheses around the product node.
Github discussion:
#43364
Change-Id: I7879bfc2cc62af63dd7598d380e10e96426ff5dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5087987
Reviewed-by: Anders Hartvoll Ruud <[email protected]>
Commit-Queue: Daniil Sakhapov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1233345}