Change parentheses condition for css math serialization #43364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Nov 27, 2023
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5062788
branch
4 times, most recently
from
94365ae to
2d91ab2
Compare
Previously the condition for adding parentheses for serialization was vast and caused every arithmetic operation to be in parentheses. With time a lot of simplifications were added and now the only case where we can end up with parentheses is when either operand of the multiplication/division is unsimplified add/sub node: (lhs as unsimplified add/sub) [* or /] rhs or lhs [* or /] (rhs as unsimplified add/sub). Change-Id: I7a4d881357205b8c317029cb2c65548a2a39a80f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5062788 Commit-Queue: Daniil Sakhapov <[email protected]> Reviewed-by: Anders Hartvoll Ruud <[email protected]> Cr-Commit-Position: refs/heads/main@{#1230040}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5062788
branch
from
2d91ab2 to
fa5ecc7
Compare
|
@danielsakhapov I believe the new test expectation is invalid per https://drafts.csswg.org/css-values/#serialize-a-calculation-tree, and Firefox and Safari are correct. Can you confirm? |
|
cc @nt1m |
|
Yes, I agree, I'll revert the test change, sorry for that. |
|
Maybe? It's weird to account for operand priority but could be done. Maybe file a spec issue? |
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Dec 5, 2023
Add parentheses around multiplication operation as per spec: https://drafts.csswg.org/css-values/#serialize-a-calculation-tree we should add parentheses around the product node. Github discussion: #43364 Change-Id: I7879bfc2cc62af63dd7598d380e10e96426ff5dd
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Dec 5, 2023
Add parentheses around multiplication operation as per spec: https://drafts.csswg.org/css-values/#serialize-a-calculation-tree we should add parentheses around the product node. Github discussion: web-platform-tests/wpt#43364 Change-Id: I7879bfc2cc62af63dd7598d380e10e96426ff5dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5087987 Reviewed-by: Anders Hartvoll Ruud <[email protected]> Commit-Queue: Daniil Sakhapov <[email protected]> Cr-Commit-Position: refs/heads/main@{#1233345}
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Dec 5, 2023
Add parentheses around multiplication operation as per spec: https://drafts.csswg.org/css-values/#serialize-a-calculation-tree we should add parentheses around the product node. Github discussion: #43364 Change-Id: I7879bfc2cc62af63dd7598d380e10e96426ff5dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5087987 Reviewed-by: Anders Hartvoll Ruud <[email protected]> Commit-Queue: Daniil Sakhapov <[email protected]> Cr-Commit-Position: refs/heads/main@{#1233345}
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Dec 5, 2023
Add parentheses around multiplication operation as per spec: https://drafts.csswg.org/css-values/#serialize-a-calculation-tree we should add parentheses around the product node. Github discussion: #43364 Change-Id: I7879bfc2cc62af63dd7598d380e10e96426ff5dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5087987 Reviewed-by: Anders Hartvoll Ruud <[email protected]> Commit-Queue: Daniil Sakhapov <[email protected]> Cr-Commit-Position: refs/heads/main@{#1233345}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Dec 14, 2023
…s serialization test, a=testonly Automatic update from web-platform-tests Change parentheses for css math functions serialization test Add parentheses around multiplication operation as per spec: https://drafts.csswg.org/css-values/#serialize-a-calculation-tree we should add parentheses around the product node. Github discussion: web-platform-tests/wpt#43364 Change-Id: I7879bfc2cc62af63dd7598d380e10e96426ff5dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5087987 Reviewed-by: Anders Hartvoll Ruud <[email protected]> Commit-Queue: Daniil Sakhapov <[email protected]> Cr-Commit-Position: refs/heads/main@{#1233345} -- wpt-commits: 27ed8f45421a9329cb918aa82c3c22f634925061 wpt-pr: 43513
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Dec 16, 2023
…s serialization test, a=testonly Automatic update from web-platform-tests Change parentheses for css math functions serialization test Add parentheses around multiplication operation as per spec: https://drafts.csswg.org/css-values/#serialize-a-calculation-tree we should add parentheses around the product node. Github discussion: web-platform-tests/wpt#43364 Change-Id: I7879bfc2cc62af63dd7598d380e10e96426ff5dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5087987 Reviewed-by: Anders Hartvoll Ruud <andruudchromium.org> Commit-Queue: Daniil Sakhapov <sakhapovchromium.org> Cr-Commit-Position: refs/heads/main{#1233345} -- wpt-commits: 27ed8f45421a9329cb918aa82c3c22f634925061 wpt-pr: 43513 UltraBlame original commit: 2047dad9ea5945b66b3c548e8e56391b3528568d
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Dec 16, 2023
…s serialization test, a=testonly Automatic update from web-platform-tests Change parentheses for css math functions serialization test Add parentheses around multiplication operation as per spec: https://drafts.csswg.org/css-values/#serialize-a-calculation-tree we should add parentheses around the product node. Github discussion: web-platform-tests/wpt#43364 Change-Id: I7879bfc2cc62af63dd7598d380e10e96426ff5dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5087987 Reviewed-by: Anders Hartvoll Ruud <andruudchromium.org> Commit-Queue: Daniil Sakhapov <sakhapovchromium.org> Cr-Commit-Position: refs/heads/main{#1233345} -- wpt-commits: 27ed8f45421a9329cb918aa82c3c22f634925061 wpt-pr: 43513 UltraBlame original commit: 2047dad9ea5945b66b3c548e8e56391b3528568d
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Dec 16, 2023
…s serialization test, a=testonly Automatic update from web-platform-tests Change parentheses for css math functions serialization test Add parentheses around multiplication operation as per spec: https://drafts.csswg.org/css-values/#serialize-a-calculation-tree we should add parentheses around the product node. Github discussion: web-platform-tests/wpt#43364 Change-Id: I7879bfc2cc62af63dd7598d380e10e96426ff5dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5087987 Reviewed-by: Anders Hartvoll Ruud <andruudchromium.org> Commit-Queue: Daniil Sakhapov <sakhapovchromium.org> Cr-Commit-Position: refs/heads/main{#1233345} -- wpt-commits: 27ed8f45421a9329cb918aa82c3c22f634925061 wpt-pr: 43513 UltraBlame original commit: 2047dad9ea5945b66b3c548e8e56391b3528568d
aosmond
pushed a commit
to aosmond/gecko
that referenced
this pull request
Dec 16, 2023
…s serialization test, a=testonly Automatic update from web-platform-tests Change parentheses for css math functions serialization test Add parentheses around multiplication operation as per spec: https://drafts.csswg.org/css-values/#serialize-a-calculation-tree we should add parentheses around the product node. Github discussion: web-platform-tests/wpt#43364 Change-Id: I7879bfc2cc62af63dd7598d380e10e96426ff5dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5087987 Reviewed-by: Anders Hartvoll Ruud <[email protected]> Commit-Queue: Daniil Sakhapov <[email protected]> Cr-Commit-Position: refs/heads/main@{#1233345} -- wpt-commits: 27ed8f45421a9329cb918aa82c3c22f634925061 wpt-pr: 43513
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the condition for adding parentheses for serialization
was vast and caused every arithmetic operation to be in parentheses.
With time a lot of simplifications were added and now the only case
where we can end up with parentheses is when either operand
of the multiplication/division is unsimplified add/sub node:
(lhs as unsimplified add/sub) [* or /] rhs
or
lhs [* or /] (rhs as unsimplified add/sub).
Change-Id: I7a4d881357205b8c317029cb2c65548a2a39a80f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5062788
Commit-Queue: Daniil Sakhapov <[email protected]>
Reviewed-by: Anders Hartvoll Ruud <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1230040}