Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automated tests of insertParagraph and insertLineBreak insert… #41036

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

masayuki-nakano
Copy link
Contributor

@masayuki-nakano masayuki-nakano commented Jul 14, 2023

insertParagraph and insertLineBreak at
<span contenteditable>foo[]</span><div>bar</div> requires 2 line breaks to make the last empty line visible. This changeset adds the tests.

Fixes web-platform-tests/interop#368

…s 2 line breaks at end of `<span contenteditable>` if it's followed by a `<div>`

`insertParagraph` and `insertLineBreak` at
`<span contenteditable>foo[]</span><div>bar</div>` requires 2 line
breaks to make the last empty line visible.  This changeset adds the
tests.

web-platform-tests/interop#368
@foolip
Copy link
Member

foolip commented Sep 28, 2023

I'm going to close and reopen the pull request to retrigger the tests in Chrome/Firefox/Safari, so we can see if the new tests are going to be failing or not.

@foolip foolip closed this Sep 28, 2023
@foolip foolip reopened this Sep 28, 2023
Copy link
Contributor

@xiaochengh xiaochengh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from Chromium

@nt1m nt1m merged commit eea2d9d into master Oct 12, 2023
@nt1m nt1m deleted the inline-editing-host branch October 12, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add testcases for that <span contenteditable> is followed by <div>
6 participants