Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add testcases for that <span contenteditable> is followed by <div> #368

Closed
masayuki-nakano opened this issue Jun 28, 2023 · 10 comments · Fixed by web-platform-tests/wpt#41036
Closed

Add testcases for that <span contenteditable> is followed by <div> #368

masayuki-nakano opened this issue Jun 28, 2023 · 10 comments · Fixed by web-platform-tests/wpt#41036
Labels
focus area: Web Compat 2023 test-change-proposal Proposal to add or remove tests for an interop area

Comments

@masayuki-nakano
Copy link

Test List

https://wpt.fyi/results/?label=master&label=experimental&aligned&q=%2Fediting%2Fother%2Finsertparagraph-in-inline-editing-host.tentative.html

Rationale

I forgot to put the testcases into the test. If insertParagraph at <span contenteditable>foo[]</span><div>bar</div> occurs, <span contenteditable>foo<br></span><div>bar</div> is not enough to make the new empty line visible. The builtin editors need to make it <span contenteditable>foo<br><br></span><div>bar</div>.

I think we should duplicate those tests and replace the outer <br> element with <div>efg</div>.
@masayuki-nakano masayuki-nakano added the test-change-proposal Proposal to add or remove tests for an interop area label Jun 28, 2023
@nt1m
Copy link
Member

nt1m commented Jul 5, 2023

@masayuki-nakano Could you put up a PR of what the test changes would look like?

@masayuki-nakano
Copy link
Author

(Sorry for the delay to reply, I was on a short vacation, I'll post it in this week.)

masayuki-nakano added a commit to web-platform-tests/wpt that referenced this issue Jul 14, 2023
@masayuki-nakano
Add automated tests of insertParagraph and insertLineBreak insert…
1a48b76 
…s 2 line breaks at end of `<span contenteditable>` if it's followed by a `<div>`

`insertParagraph` and `insertLineBreak` at
`<span contenteditable>foo[]</span><div>bar</div>` requires 2 line
breaks to make the last empty line visible.  This changeset adds the
tests.

web-platform-tests/interop#368
@masayuki-nakano masayuki-nakano mentioned this issue Jul 14, 2023
Merged
@nt1m
Copy link
Member

nt1m commented Jul 15, 2023

Seems ok to me

@nairnandu
Copy link
Contributor

@jgraham / @zcorpan could you review the proposed change for Gecko?
@kojiishi could you review the proposed change for Chromium?

@jgraham
Copy link
Contributor

jgraham commented Aug 10, 2023

@masayuki-nakano is working on Gecko, so I think we need Chromium input on this one.

@meyerweb meyerweb mentioned this issue Aug 10, 2023
Closed
@chrishtr
Copy link
Contributor

Approved from Chromium.

@nt1m
Copy link
Member

nt1m commented Sep 4, 2023

@masayuki-nakano Please feel free to merge the PR and close this issue fwiw.

@masayuki-nakano
Copy link
Author

@nt1m Nobody has reviewed my patch so that I cannot merge the PR.

@nt1m
Copy link
Member

nt1m commented Sep 4, 2023

@makotokato / @rniwa Can you help take a look at this PR: web-platform-tests/wpt#41036 ?

@nairnandu
Copy link
Contributor

nairnandu commented Sep 28, 2023 •
edited
Loading

@kojiishi / @xiaochengh / @makotokato / @rniwa could you help review the PR: web-platform-tests/wpt#41036 ?

nt1m pushed a commit to web-platform-tests/wpt that referenced this issue Oct 12, 2023
@masayuki-nakano
Add automated tests of insertParagraph and insertLineBreak insert…
eea2d9d 
…s 2 line breaks at end of `<span contenteditable>` if it's followed by a `<div>` (#41036)

`insertParagraph` and `insertLineBreak` at
`<span contenteditable>foo[]</span><div>bar</div>` requires 2 line
breaks to make the last empty line visible.  This changeset adds the
tests.

Fixes web-platform-tests/interop#368
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Oct 26, 2023
@masayuki-nakano @moz-wptsync-bot
Bug 1843472 [wpt PR 41036] - Add automated tests of insertParagraph…
e0941da 
… and `insertLineBreak` insert…, a=testonly

Automatic update from web-platform-tests
Add automated tests of `insertParagraph` and `insertLineBreak` inserts 2 line breaks at end of `<span contenteditable>` if it's followed by a `<div>` (#41036)

`insertParagraph` and `insertLineBreak` at
`<span contenteditable>foo[]</span><div>bar</div>` requires 2 line
breaks to make the last empty line visible.  This changeset adds the
tests.

Fixes web-platform-tests/interop#368
--

wpt-commits: eea2d9d3d90981ff559e9b9868e3211b38841d1c
wpt-pr: 41036
ErichDonGubler pushed a commit to erichdongubler-mozilla/firefox that referenced this issue Oct 27, 2023
@masayuki-nakano @moz-wptsync-bot
Bug 1843472 [wpt PR 41036] - Add automated tests of insertParagraph…
7ca89c5 
… and `insertLineBreak` insert…, a=testonly

Automatic update from web-platform-tests
Add automated tests of `insertParagraph` and `insertLineBreak` inserts 2 line breaks at end of `<span contenteditable>` if it's followed by a `<div>` (#41036)

`insertParagraph` and `insertLineBreak` at
`<span contenteditable>foo[]</span><div>bar</div>` requires 2 line
breaks to make the last empty line visible.  This changeset adds the
tests.

Fixes web-platform-tests/interop#368
--

wpt-commits: eea2d9d3d90981ff559e9b9868e3211b38841d1c
wpt-pr: 41036
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Oct 30, 2023
@marco-c
Bug 1843472 [wpt PR 41036] - Add automated tests of insertParagraph…
4eec964 
… and `insertLineBreak` insert…, a=testonly

Automatic update from web-platform-tests
Add automated tests of `insertParagraph` and `insertLineBreak` inserts 2 line breaks at end of `<span contenteditable>` if it's followed by a `<div>` (#41036)

`insertParagraph` and `insertLineBreak` at
`<span contenteditable>foo[]</span><div>bar</div>` requires 2 line
breaks to make the last empty line visible.  This changeset adds the
tests.

Fixes web-platform-tests/interop#368
--

wpt-commits: eea2d9d3d90981ff559e9b9868e3211b38841d1c
wpt-pr: 41036

UltraBlame original commit: 6aa7226dcc167d8b94477e2246df2d8174206cd3
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Oct 30, 2023
@marco-c
Bug 1843472 [wpt PR 41036] - Add automated tests of insertParagraph…
d4b0e67 
… and `insertLineBreak` insert…, a=testonly

Automatic update from web-platform-tests
Add automated tests of `insertParagraph` and `insertLineBreak` inserts 2 line breaks at end of `<span contenteditable>` if it's followed by a `<div>` (#41036)

`insertParagraph` and `insertLineBreak` at
`<span contenteditable>foo[]</span><div>bar</div>` requires 2 line
breaks to make the last empty line visible.  This changeset adds the
tests.

Fixes web-platform-tests/interop#368
--

wpt-commits: eea2d9d3d90981ff559e9b9868e3211b38841d1c
wpt-pr: 41036

UltraBlame original commit: 6aa7226dcc167d8b94477e2246df2d8174206cd3
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Oct 30, 2023
@marco-c
Bug 1843472 [wpt PR 41036] - Add automated tests of insertParagraph…
410a546 
… and `insertLineBreak` insert…, a=testonly

Automatic update from web-platform-tests
Add automated tests of `insertParagraph` and `insertLineBreak` inserts 2 line breaks at end of `<span contenteditable>` if it's followed by a `<div>` (#41036)

`insertParagraph` and `insertLineBreak` at
`<span contenteditable>foo[]</span><div>bar</div>` requires 2 line
breaks to make the last empty line visible.  This changeset adds the
tests.

Fixes web-platform-tests/interop#368
--

wpt-commits: eea2d9d3d90981ff559e9b9868e3211b38841d1c
wpt-pr: 41036

UltraBlame original commit: 6aa7226dcc167d8b94477e2246df2d8174206cd3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
focus area: Web Compat 2023 test-change-proposal Proposal to add or remove tests for an interop area
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add automated tests of insertParagraph and insertLineBreak insert… web-platform-tests/wpt
5 participants
@jgraham @nt1m @nairnandu @chrishtr @masayuki-nakano