[ComputePressure] Remove CPU frequency information. #34890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CPU frequency statistics are not a good metric. A CPU can have multiple boost modes depending on which core is running and depending on whether on AC or DC power. We cannot deduct that a CPU is stressed just because it is running at a high frequency. Also it might be running at a lower frequency due to power settings or being on DC power and then the system can easily be under pressure at this lower frequency. (GitHub issue: w3c/compute-pressure#24, Spec change: w3c/compute-pressure@e3da844). We remove CPU frequency information from the implementation in this patch and use only CPU utilization temporarily. We will switch to PressureState in the future according to the newest spec (https://wicg.github.io/compute-pressure/#pressure-states) and we are working on a robust algorithm to calculate PressureState. Bug: 1339205 Change-Id: I15a17fd1eefeeefaddc5f3df5e2a98b04cac4368 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3725753 Reviewed-by: Matthew Denton <[email protected]> Commit-Queue: Wei4 Wang <[email protected]> Reviewed-by: Raphael Kubo Da Costa <[email protected]> Reviewed-by: Reilly Grant <[email protected]> Cr-Commit-Position: refs/heads/main@{#1025486}
|
#34875 indicates the STP failures were fixed after the initial checks ran. Retrying. |
|
It looks like the PR bot forgot to review this one, but the PR is otherwise OK to merge onto |
DanielRyanSmith
approved these changes
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CPU frequency statistics are not a good metric. A CPU can
have multiple boost modes depending on which core is running
and depending on whether on AC or DC power. We cannot deduct
that a CPU is stressed just because it is running at a high
frequency. Also it might be running at a lower frequency due
to power settings or being on DC power and then the system
can easily be under pressure at this lower frequency. (GitHub
issue: w3c/compute-pressure#24,
Spec change: w3c/compute-pressure@e3da844).
We remove CPU frequency information from the implementation
in this patch and use only CPU utilization temporarily. We
will switch to PressureState in the future according to the
newest spec (https://wicg.github.io/compute-pressure/#pressure-states)
and we are working on a robust algorithm to calculate
PressureState.
Bug: 1339205
Change-Id: I15a17fd1eefeeefaddc5f3df5e2a98b04cac4368
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3725753
Reviewed-by: Matthew Denton <[email protected]>
Commit-Queue: Wei4 Wang <[email protected]>
Reviewed-by: Raphael Kubo Da Costa <[email protected]>
Reviewed-by: Reilly Grant <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1025486}