Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Safari Technology Preview downloads are failing after page update #34875

Closed
jcscottiii opened this issue Jul 18, 2022 · 1 comment · Fixed by #34885
Closed

Safari Technology Preview downloads are failing after page update #34875

jcscottiii opened this issue Jul 18, 2022 · 1 comment · Fixed by #34885
Labels
infra

Comments

@jcscottiii
Copy link
Contributor

Pipeline run

Traceback (most recent call last):
  File "/Users/runner/work/1/s/./wpt", line 10, in <module>
    wpt.main()
  File "/Users/runner/work/1/s/tools/wpt/wpt.py", line 220, in main
    rv = script(*args, **kwargs)
  File "/Users/runner/work/1/s/tools/wpt/install.py", line 89, in run
    install(browser, kwargs["component"], destination, channel, logger=logger,
  File "/Users/runner/work/1/s/tools/wpt/install.py", line 109, in install
    path = getattr(browser_cls(logger), method)(dest=destination, channel=channel, **kwargs)
  File "/Users/runner/work/1/s/tools/wpt/browser.py", line 1612, in download
    image_path = self._download_image(stp_downloads, tmpdir, system_version)
  File "/Users/runner/work/1/s/tools/wpt/browser.py", line 1530, in _download_image
    raise ValueError(f"no download for {system_version}")
ValueError: no download for 12.4

Similar to #34752

Looks like the page has changed.
Here's a diff between the file created for testing and now

 <div class="column large-6 medium-12 small-12">
     <div class="callout">
-        <figure class="app-icon large-icon safari-preview-icon" aria-hidden="true" data-hires-status="pending"></figure>
+        <figure class="app-icon large-icon safari-preview-icon" aria-hidden="true"></figure>
         <h4>Safari Technology Preview</h4>
         <p class="margin-bottom-small">Get a sneak peek at upcoming web technologies in macOS and iOS with <a href="/safari/technology-preview/" class="nowrap">Safari Technology Preview</a> and experiment with these technologies in your websites and extensions.</p>
         <ul class="links small">
-            <li class="dmg" data-hires-status="pending"><a class="inline" href="https://secure-appldnld.apple.com/STP/012-38225-20220706-237860CD-5766-4F53-AAC7-1CE26023A959/SafariTechnologyPreview.dmg">Safari Technology Preview<br>for macOS&nbsp;Ventura</a><br><span class="smaller lighter nowrap nowrap-small">Requires macOS&nbsp;13 beta&nbsp;3 or later.</span></li>
-            <li class="dmg margin-top-small" data-hires-status="pending"><a class="inline" href="https://secure-appldnld.apple.com/STP/012-32918-20220629-B3452905-0138-4CA9-A4E6-334B63585653/SafariTechnologyPreview.dmg">Safari Technology Preview<br>for macOS&nbsp;Monterey</a><br><span class="smaller lighter">Requires macOS&nbsp;12.3 or later.</span></li>
-            <li class="document margin-top-small" data-hires-status="pending"><a href="/safari/technology-preview/release-notes/">Release Notes</a></li>
+            <li class="dmg"><a class="inline" href="https://secure-appldnld.apple.com/STP/012-38225-20220706-237860CD-5766-4F53-AAC7-1CE26023A959/SafariTechnologyPreview.dmg">Safari Technology Preview 148<br />for macOS&nbsp;Ventura</a><br /><span class="smaller lighter nowrap nowrap-small">Requires macOS&nbsp;13 beta&nbsp;3 or later.</span></li>
+            <li class="dmg margin-top-small"><a class="inline" href="https://secure-appldnld.apple.com/STP/012-38074-20220715-4851625A-8AC7-4155-84C0-AEB4B88F08FE/SafariTechnologyPreview.dmg">Safari Technology Preview 149<br />for macOS&nbsp;Monterey</a><br /><span class="smaller lighter">Requires macOS&nbsp;12.3 or later.</span></li>
+            <li class="document margin-top-small"><a href="/safari/technology-preview/release-notes/">Release Notes</a></li>
         </ul>
         <div class="row gutter text-left">
             <div class="column">
                 <p class="sosumi no-margin-bottom margin-top-small">Release</p>
-                <p class="smaller lighter no-margin">148</p>
+                <p class="smaller lighter no-margin">149</p>
             </div>
             <div class="column">
                 <p class="sosumi no-margin-bottom margin-top-small">Posted</p>
-                <p class="smaller lighter no-margin">June 29, 2022</p>
+                <p class="smaller lighter no-margin">July 14, 2022</p>
             </div>
         </div>
     </div>

@gsnedders
@jcscottiii
Copy link
Contributor Author

I can make a PR for this @gsnedders
I see that there is now a number there:

Previously:
Safari Technology Preview<br>for macOS&nbsp;Ventura

Now:
Safari Technology Preview 148<br />for macOS&nbsp;Ventura

jcscottiii added a commit to jcscottiii/wpt that referenced this issue Jul 18, 2022
@jcscottiii
Fix regex for STP downloads
22b374a 
On July 14, 2022, the page was updated.

Example of STP line item previously:
Safari Technology Preview<br>for macOS&nbsp;Ventura

Example of STP line item now:
Safari Technology Preview 148<br />for macOS&nbsp;Ventura

Changes:
- Change regex to work with the format while maintaining backwards
  compatibility in case the old version comes back
- Add a test case to cover the new format
- Reformat tests to loop through the various test data files to test
  both scenarios

Fixes web-platform-tests#34875
@jcscottiii jcscottiii mentioned this issue Jul 18, 2022
Closed
jcscottiii added a commit to jcscottiii/wpt that referenced this issue Jul 18, 2022
@jcscottiii
Fix regex for STP downloads
5613c63 
On July 14, 2022, the page was updated.

Example of STP line item previously:
Safari Technology Preview<br>for macOS&nbsp;Ventura

Example of STP line item now:
Safari Technology Preview 148<br />for macOS&nbsp;Ventura

Changes:
- Change regex to work with the format while maintaining backwards
  compatibility in case the old version comes back
- Add a test case to cover the new format
- Reformat tests to loop through the various test data files to test
  both scenarios

Fixes web-platform-tests#34875
This was referenced Jul 18, 2022
Merged
Merged
@jonathan-j-lee jonathan-j-lee mentioned this issue Jul 19, 2022
Merged
@foolip foolip mentioned this issue Sep 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
infra
Projects
None yet
Milestone
No milestone
1 participant
@jcscottiii