testdriver.js: Make set_permission() take a PermissionDescriptor, not a name #20674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
added
infra
testdriver.js
wptrunner
… a name Making the public API take a permission name only works for permissions that take a `PermissionDescriptor`, and makes it impossible to set permissions that require extra information (i.e. they take a `MidiPermissionDescriptor` or a `PushPermissionDescriptor` instead). Instead of taking a string corresponding to a permission name, take a `PermissionDescriptor` directly so that all required information can be specified. While here, make `set_permission.html` an HTTPS test, as some permissions are only available in a secure context (such as "push", which is being used to test setting a permission that requires extra parameters in the descriptor). Fixes web-platform-tests#20672.
rakuco
force-pushed
the
testdriver-set_permission-descriptor
branch
from
9a540cd to
5cb79c7
Compare
|
The TaskCluster failures seem to be a result of a lot of tests running for more than 2h. |
LukeZielinski
approved these changes
Dec 9, 2019
|
@foolip et al: I think I need a hand force-merging this PR, the TaskCluster failures seem to be unrelated. |
|
Oh, no, this is just #15485. |
|
Thanks, @gsnedders! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making the public API take a permission name only works for permissions that
take a
PermissionDescriptor, and makes it impossible to set permissionsthat require extra information (i.e. they take a
MidiPermissionDescriptoror a
PushPermissionDescriptorinstead).Instead of taking a string corresponding to a permission name, take a
PermissionDescriptordirectly so that all required information can bespecified.
While here, make
set_permission.htmlan HTTPS test, as some permissionsare only available in a secure context (such as "push", which is being used
to test setting a permission that requires extra parameters in the
descriptor).
Fixes #20672.