-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Special case testdriver.js when detecting affected tests #15485
Comments
@LukeZielinski can you take a look at this? Does touching testdriver.js currently cause stability checks to time out, or how much margin do we have? A similar case is idlharness.js where @lukebjerring added code to run more affected tests, but in that case we don't expect the number of tests to ever go much beyond the total number of specs/directories. |
#13392 is the change mentioned |
So empirically (#16852) the stability checks were not run for a no-op change to testdriver.js. Although it's kind of surprising, since (as you said) only Is there some other configuration at play here? |
@jgraham do you know why touching testdriver.js won't end up running any tests? I'm pretty sure it once did, and I haven't changed it or been aware of a change. |
Ping @jgraham on #15485 (comment). |
Marking roadmap due to inactivity (and lack of concern about inactivity) |
IIRC,
testharness.js
is treated specially in the heuristics for detecting affected tests (whenever it's modified almost all tests are affected). I think we need to do the same fortestdriver.js
as its use increases.The text was updated successfully, but these errors were encountered: