move interop data outside of static (fixes #3132) #3205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Staging environment looks as expected. We should keep an eye on this during deployment to make sure this truly avoids the caching issue we encountered.
I'll let @KyleJu give final approvals since he discovered the root cause of the problem to begin with.
KyleJu
approved these changes
Mar 14, 2023
|
@racheljay Thank you for the PR! |
|
Should we delete the JSON file to avoid confusion? |
Good point. I just created a pr (#3208) to fix this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR moves the data that was previously in
components/static/interop-data.jsonto a.jsfile outside of the static directory as outlined in the discussion for #3142.Changes
components/static/interop-data.jsonwas previously removed and this PR adds that data tocomponents/interop-data.js. It is now imported directly intointerop.jsand accessed byfetchYearData().