-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Take steps to avoid serving an outdated version of the interop category data #3142
Comments
Do you know at what layer the caching was and whether the /api URLs are immune to the same problem? |
After some digging, it is caused by the GCP default cache for all static files, as shown by The JSON filed lives under static/interop-data_v2.json. We have a default expiration for 24 hours for this type of cache. Ideally moving it out of the static file folder should solve the problem, or even put them in the wpt-interop Javascript. We also cache all the files served by the component handler. So as long as this file is not served through component handler API, having a separate API endpoint should work. |
Here's a possible improvement for this: We do this in ChromeStatus. We can do the same thing for the template that renders interop.js. When the backend renders the page, the browser will cache “interop.js?v=VERSION” which will change between version deployments. As a result, it will retrieve the new version of interop.js for VERSION+1. |
I would like to take a look at this issue. To make sure I'm understanding correctly, we want to make sure that fetchYearData() is pulling the most recent data available and not the cached version of |
Hello @racheljay! Thanks for the inquiry, and any help is welcome. From my understanding of @KyleJu's explanation of the specific cause of our problem, the most important requirement here is to move this data out of the |
Closing this now, as I believe we've addressed this to avoid it in the future. Thanks for the help @racheljay! |
Upon releasing the Interop 2023 dashboard, some users were unable to see the page because the site would sometimes reference an older cached version of
webapp/static/interop-data.json
that did not have Interop 2023 category data. The file was renamed to ensure the latest version was referenced, but ideally this category data would be pulled from an endpoint rather than referenced in its current form to avoid this situation from happening again.The text was updated successfully, but these errors were encountered: