Skip to content
This repository has been archived by the owner on Nov 6, 2019. It is now read-only.

Derive and include a "commit_date" for new TestRun entities. Ref gh-154 #383

Merged
merged 1 commit into from
Feb 6, 2018
Merged

Derive and include a "commit_date" for new TestRun entities. Ref gh-154 #383

merged 1 commit into from
Feb 6, 2018

Conversation

rwaldron
Copy link
Contributor

@rwaldron rwaldron commented Jan 22, 2018 •
edited by lukebjerring
Loading

See #154 for context.

@rwaldron rwaldron self-assigned this Jan 22, 2018
@boazsender boazsender assigned rwaldron and unassigned rwaldron Jan 22, 2018
@rwaldron rwaldron mentioned this pull request Jan 22, 2018
Merged
@foolip foolip mentioned this pull request Jan 24, 2018
Closed
@rwaldron
Copy link
Contributor Author

Rebased!

rwaldron
rwaldron commented Jan 25, 2018
View reviewed changes
run/run_test.py
def test_get_commit_details_find_sha(self,
mock_sha_finder,
mock_call,
mock_check_output):
Copy link
Contributor Author

@rwaldron rwaldron Jan 25, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This indent is an odd quantity of spaces because pycodestyle insisted

¯\_(ツ)_/¯

@rwaldron rwaldron force-pushed the 154 branch 3 times, most recently from e066b7c to 6ee5f13 Compare January 29, 2018 16:46
@rwaldron rwaldron mentioned this pull request Jan 29, 2018
Closed
3 tasks
@rwaldron
Copy link
Contributor Author

These failures are completely effing bogus.

https://travis-ci.org/w3c/wptdashboard/jobs/334786144

protoc -I../protobuf/src -I../protoc-gen-bq-schema -Iprotos \
	--python_out=run/protos protos/test_run.proto protos/token.proto protos/strawman.proto protos/browser.proto
bq_table_name.proto: File not found.
strawman.proto: Import "bq_table_name.proto" was not found or had errors.
Makefile:67: recipe for target 'py_proto' failed
make: *** [py_proto] Error 1

https://travis-ci.org/w3c/wptdashboard/jobs/334786145

protoc -I../protobuf/src -I../protoc-gen-bq-schema -Iprotos \
	--python_out=run/protos protos/test_run.proto protos/token.proto protos/strawman.proto protos/browser.proto
bq_table_name.proto: File not found.
strawman.proto: Import "bq_table_name.proto" was not found or had errors.
Makefile:67: recipe for target 'py_proto' failed
make: *** [py_proto] Error 1

https://travis-ci.org/w3c/wptdashboard/jobs/334786150

protoc -I../protobuf/src -I../protoc-gen-bq-schema -Iprotos \
	--bq-schema_out=bq-schema protos/test_run.proto protos/token.proto protos/strawman.proto protos/browser.proto
bq_table_name.proto: File not found.
strawman.proto: Import "bq_table_name.proto" was not found or had errors.
Makefile:57: recipe for target 'bq_proto' failed
make: *** [bq_proto] Error 1

... None of these are my problem.

@lukebjerring
Copy link
Collaborator

Build failures are indeed irrelevant; a Golang dep made a breaking change. See #412 for build-fix.

@rwaldron rwaldron force-pushed the 154 branch 3 times, most recently from c6c04c1 to d72ca8e Compare February 6, 2018 16:26
@rwaldron rwaldron mentioned this pull request Feb 6, 2018
Closed
@rwaldron rwaldron merged commit 6ba463d into master Feb 6, 2018
@lukebjerring lukebjerring mentioned this pull request Apr 10, 2018
Closed
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@rwaldron rwaldron

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rwaldron @lukebjerring