-
Notifications
You must be signed in to change notification settings - Fork 46
Latest run upload was 2 weeks ago (Nov 14) #273
Comments
I've been working to get the dashboard running locally and hitting some issues. Right now, we're getting incomplete runs which leaves the dashboard empty, so we've been manually tweaking it to show older results. I'd like to see some better documentation on this, and I need to make a start on that. @jeffcarp -- I see Chrome is lacking from https://ci.wpt.fyi/ -- where is it running? |
@mattl Chrome is still running in its own VM ( Documentation is definitely lacking, due to the fast pace and the project having only 1 contributor for most of its history. As things settle on Jenkins I'd love to spruce up the docs. Feel free to reach out to me on IRC with any questions, there's a lot of undocumented context I can share. Specifically I can help you log into the Chrome VM.
What issues are you running into? Not sure if this was clear but the wpt.fyi (App Engine) server isn't necessary for debugging test runs. (The test running & result serving projects are intentionally isolated from each other except for the one call the runners make at the end to create a new |
So I did a bit more digging around yesterday, and thanks to Jeff pointing me in the right direction with Google Cloud I found the various places Jenkins is running and got runs starting again. They're failing immediately with a few errors including not being able to find Looking at the Dockerfiles, I see that tl;dr: Things are still failing, but they're failing quickly and consistently. I can get stuck into debugging this momentarily. |
Mike West noticed this and asked me about it today, so people who like wpt.fyi and are trying to use it are noticing. Updating the issue title to reflect that it's now 2 weeks. |
@mikewest has been reloading the page daily for a while now. I assumed that it wasn't going anywhere over the Thanksgiving week, but was a bit surprised to see it still broken today after a post-turkey Monday in Mountain View. :) Not a huge deal, but I'd like to have something public to point to that shows two interoperable implementations of some things I'd like to advance through W3C process. |
Ping? Any update on the site status? |
@mattl got a new Firefox run this week, and was going to upload a Chrome run today. In the meantime, it looks like we've automatically gotten a new partial Chrome run, which should be deleted. Updates should happen on this issue, but here's also an in-progress postmortem: |
Chrome is getting close, hitting a crash in the script right now. https://drive.google.com/file/d/1LTRK9uNx_9lJMx7cCZxWPdZSb-ZF-ruo/view |
@mattl FWIW, that to me looks like a bug in wptrunner, as we should eventually set the result of those WebDriver tests to TIMEOUT if it hangs. |
That's helpful. I'll be looking there next :) |
@AutomatedTester was looking at updating the pytest version, which I think he believes helps here? At the same time, the way we handle this isn't perfect since we more or less rely on killing the runner process to do the right thing, and don't attempt to stop pytest itself. |
Where we're at today:
Next steps:
|
Sweet! Given that Chrome and Firefox builds are still manual, would it be much effort to also ensure that they're testing the same commit? Or do you think that this bit will be easier once everything is in Jenkins? |
Hah, that is so cute :) Try |
Doesn't |
Also note that |
@jgraham oh, I didn't know, I just made some guesses. |
We have a successful Safari build up on the site. |
Very happy to report that Safari is now automatically uploading its results to the dashboard daily. |
I'm really happy to see the Safari results! Will automation for Chrome and Firefox return in the near future? :) |
Chrome and Firefox will be back today. I’ve put off those while I focused
on getting Edge and Safari running.
Edge has run today but not to completion, but I’m pretty sure I know why.
Safari has now completed three runs in a row. I’m very pleased with that
result.
Tomorrow is my last working day this year so I’ll be focused on getting as
much automated as possible.
…--
Matt Lee
Sr. Open Web Engineer, Bocoup.
https://bocoup.com/about/bocouper/mattl
|
If the system will be left running unsupervised, can you add in a rule like having run >20k tests or similar so that we don't get very partial runs pushed live? |
Good idea. I’ll hack something up.
|
What is the total number of tests for the latest runs of each now? It's hard to tell from wpt.fyi, and intentionally so :) |
Update: Good news -- I had two VMs running the Edge tests, and one passed. Check https://wpt.fyi -- we have a new Edge run for the first time in 36 days. |
Oh, sweet, https://wpt.fyi/ looking better than ever! @mdittmer, can you update https://metrics5-dot-wptdashboard.appspot.com/metrics/ with the latest data to see what that looks like? |
@mattl, after a quick look, what still seems suspect is:
|
Chrome is running again right now, as is Firefox. Re: Safari CSS... Look at these earlier builds: https://wpt.fyi/css?sha=95cea0bbd1 It could have been a timeout issue as Sauce is presently running both Edge and Safari tests from the same account. |
@mattl, looks like things have been running pretty well over the holidays, with the exception of #234 (comment) and Firefox not having a run since Dec 21. Do you think that this urgent issue can be closed now? If any browser's latest run becomes older than 2 weeks again, then I'd file another emergency issue :) |
Firefox's last run is now more than two weeks old. Chrome's is a week and a half... Maybe not an emergency (in which case, please do close out this issue), but I don't have the impression that things are reliably automated at the moment. |
Your impression is unfortunately correct @mikewest, we do not yet have reliable automation yet. We're beginning work on this again next week and this is our top priority for the quarter. |
Hi @mikewest, we got firefox updated to our most recent available run (January 4th). We have issues with the FF and Chrome build machines that are failing to complete their last step and upload results. We are working to isolate each step in this process to prevent failures like this from happening and to make them more recoverable when they do. |
I'm going to close this issue. We have updates working sporadically with older stable browsers, but a new approach is needed. I have identified the work needed here: #394 |
@mattl, is the old-than-it-seems Chrome run noted in #154 (comment) something that will require #394 to address, or could it be as simple as updating a directory on that VM? While the improvements are ongoing, is there a maximum age of runs that can generally be expected, if not a strong guarantee? CC @mariestaver |
Oh look at me, just talking about what remains to be done. First of all, thank you for all the hard work so far! People (me!) are using the dashboard every day, and every hour closer to current it is (statistically) an hour less waited, or tens of minutes not spent running tests manually. @mikewest, have your needs been met, or does freshness continue to be a problem? There are some odd things going on in Edge (#383) and Safari (#389) that you need to be aware of if trying to compare results. |
@foolip Chrome was running older checkouts than it should have been due to an error by me in the version of run.py on the machine (it wasn't updating the tests repo!) -- it should be back to doing current runs starting today. I will continue to look at it. We should make new issues for outstanding things, as this issue is dragging on a bit. I'll make one for Chrome now. #401 |
@foolip Our goal is for runs to be fresh / current always, BUT while we are still repairing the system from the recent issues outlined in this ticket & elsewhere, we can't set any expectations for a maximum. We will need to finish the work we discussed in our meeting recently in order to stabilize the system to a degree where we can set any maximum. In the meantime, thanks for your patience and help! |
Understood, thanks! |
See https://wpt.fyi/test-runs
The text was updated successfully, but these errors were encountered: