-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional keys to paint
#1941
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but would like to hear your thoughts on the reason for bringing those BCD keys in here, rather than flagging them in the BCD repo instead.
This feature originally made use of the web-features:paint
tags from BCD, so the other option would have been to just add other tags in the BCD repo instead.
- api.CSS.paintWorklet_static | ||
- api.PaintWorkletGlobalScope | ||
- css.types.image.paint | ||
- css.types.image.paint.additional_parameters |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add a comment here saying something like:
"At the time of writing, additional parameters are not supported anywhere. When support is added, reflect on whether this should be split into a separate feature or not".
I feel like this might unlock specific developer use cases.
My understanding is that changes to a feature should be made in this repo. They eventually will get merged in with BCD, but I'd like to avoid making feature set changes in multiple repos. |
No description provided.