Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync tags & add Firefox impl_url for CSS Paint API #25040

Merged
merged 4 commits into from
Nov 15, 2024

Conversation

skyclouds2001
Copy link
Contributor

Summary

spec at https://drafts.css-houdini.org/css-paint-api-1/Paint

the tags isn't added for PaintSize & PaintRenderingContext2D previously, per web-platform-dx/web-features#1941 and https://github.com/web-platform-dx/web-features/blob/main/features/paint.yml.dist#L18-L59

Test results and supporting details

Related issues

@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Nov 12, 2024
@skyclouds2001 skyclouds2001 marked this pull request as ready for review November 12, 2024 03:34
@skyclouds2001 skyclouds2001 changed the title Add tags & Firefox impl_url for CSS Paint API Sync tags & add Firefox impl_url for CSS Paint API Nov 12, 2024
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the sub-features have the same impl_url as the parent, let's not add it.

So let's only add it to:

  • api.PaintRenderingContext2D
  • api.PaintSize

@caugner
Copy link
Contributor

caugner commented Nov 12, 2024

@skyclouds2001 Please take a look at the failing test.

@skyclouds2001
Copy link
Contributor Author

see #24992 and #25051

@caugner caugner merged commit cc14b2d into mdn:main Nov 15, 2024
6 checks passed
@skyclouds2001 skyclouds2001 deleted the css-paint branch November 15, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants