Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-preview): do not ignore node_modules in watchOptions #1654

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

Timeless0911
Copy link
Contributor

Summary

The preview components is located in node_modules/.rspress/virtual-demo/.

We should watch node_modules to enable hot update in preview block.

Related Issue

fix: #1652

web-infra-dev/rsbuild#4058

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Dec 11, 2024

Deploy Preview for aquamarine-blini-95325f ready!

Name Link
🔨 Latest commit 0da0ded
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/67590a7fc5ab0200085bbf04
😎 Deploy Preview https://deploy-preview-1654--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 93 (🟢 up 3 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@Timeless0911 Timeless0911 merged commit c45b6b3 into main Dec 11, 2024
8 checks passed
@Timeless0911 Timeless0911 deleted the fix/preview-watch branch December 11, 2024 03:53
@Timeless0911 Timeless0911 mentioned this pull request Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: plugin-preview not rerender after code change
2 participants