Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: ignore watching files in node_modules #4058

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Conversation

chenjiahan
Copy link
Member

@chenjiahan chenjiahan commented Nov 26, 2024

Summary

Update the default watchOptions configuration to improve performance by ignoring node_modules.

This will not affect symlinked resources in monorepo, as symlinked resources are resolved to their real path by default.

Benchmark

Using the benchmark repo for testing: https://github.com/rspack-contrib/build-tools-performance

  • Memory usage reduced by 120MB
  • dev startup speed increased by 40%
  • HMR speed increased by 20~30%

20241126-104609

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

I will update the doc in another PR.

Copy link

netlify bot commented Nov 26, 2024

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit b335c0a
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/674536b20854d40008d34e42
😎 Deploy Preview https://deploy-preview-4058--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 72 (🔴 down 1 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan requested a review from 9aoy November 26, 2024 02:47
@chenjiahan chenjiahan enabled auto-merge (squash) November 26, 2024 02:51
@chenjiahan chenjiahan merged commit a05e827 into main Nov 26, 2024
11 checks passed
@chenjiahan chenjiahan deleted the ignore_node_modules_1126 branch November 26, 2024 02:55
This was referenced Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants