Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: swc minifier source map #7991

Merged
merged 2 commits into from
Sep 26, 2024
Merged

fix: swc minifier source map #7991

merged 2 commits into from
Sep 26, 2024

Conversation

SyMind
Copy link
Member

@SyMind SyMind commented Sep 26, 2024 •
edited
Loading

Summary

Fix: #7914

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack. labels Sep 26, 2024
@netlify Netlify
Copy link

netlify bot commented Sep 26, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit a7083b5
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66f4dba254301f000717b740

@SyMind
Copy link
Member Author

SyMind commented Sep 26, 2024

!eco-ci

@rspack-bot
Copy link

rspack-bot commented Sep 26, 2024 •
edited
Loading

📝 Ran ecosystem CI: Open

suite result
modernjs ✅ success
nx ❌ failure
rspress ✅ success
rslib ✅ success
rsbuild ✅ success
examples ✅ success
devserver ✅ success

@SyMind SyMind marked this pull request as ready for review September 26, 2024 04:02
@LingyuCoder LingyuCoder added this to the 1.1.0 milestone Sep 26, 2024
@LingyuCoder
Copy link
Collaborator

image

Seems no breaking change to swc plugins, need a double check @hardfist ?

@hardfist
Copy link
Contributor

!eco-ci

@rspack-bot
Copy link

rspack-bot commented Sep 26, 2024 •
edited
Loading

📝 Ran ecosystem CI: Open

suite result
modernjs ✅ success
nx ❌ failure
rspress ✅ success
rslib ✅ success
rsbuild ✅ success
examples ✅ success
devserver ✅ success

@hardfist
Copy link
Contributor

seems fine to me

@LingyuCoder LingyuCoder merged commit 7de500f into main Sep 26, 2024
29 checks passed
@LingyuCoder LingyuCoder deleted the fix-swc-minifier-source-map branch September 26, 2024 09:52
@chenjiahan chenjiahan mentioned this pull request Sep 29, 2024
Closed
@renovate renovate bot mentioned this pull request Oct 23, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LingyuCoder LingyuCoder LingyuCoder approved these changes

Assignees

@SyMind SyMind

Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

[Bug]: The source map is not working on Sentry
4 participants
@SyMind @rspack-bot @LingyuCoder @hardfist