[Bug]: The source map is not working on Sentry #7914

cjnoname · 2024-09-17T05:04:34Z

System Info

System:
OS: macOS 15.0
CPU: (10) arm64 Apple M1 Max
Memory: 2.03 GB / 64.00 GB
Shell: 5.9 - /bin/zsh
Binaries:
Node: 22.8.0 - ~/.nvm/versions/node/v22.8.0/bin/node
npm: 10.8.3 - ~/.nvm/versions/node/v22.8.0/bin/npm
bun: 1.1.27 - /usr/local/bin/bun
Browsers:
Chrome: 128.0.6613.138
Safari: 18.0

Details

The source maps stopped working on Sentry. After discussing with their team, we identified that the issue was caused by an invalid source map generated by Rspack.

When testing the source map with source-map-explorer or other tools, the following error appeared:

'Your source map refers to generated column 53099 on line 39, but the source only contains 53098 columns on that line. Please verify that you are using the correct source map.'

Approximately 70% of the source map files we tested are working, while 30% have failed.

Reproduce link

No response

Reproduce Steps

https://github.com/cjnoname/rspack-reproduce

npm run s

hardfist · 2024-09-17T05:43:57Z

please provide rspack version

cjnoname · 2024-09-17T05:44:51Z

please provide rspack version

1.0.5 the latest

cjnoname · 2024-09-17T08:27:03Z

please provide rspack version

I could send you the buggy soucemap files and mjs files via email or whatever tools but I don't want to share them with public.

gitim · 2024-09-17T12:05:59Z

I think this is the same issue as web-infra-dev/rsbuild#3433 we found that source map stopped generated properly since 1.0.1 version (probably after #7647). @cjnoname, you can try the 1.0.0 version of rspack to identify when it was broken.

cjnoname · 2024-09-17T14:34:32Z

I think this is the same issue as web-infra-dev/rsbuild#3433 we found that source map stopped generated properly since 1.0.1 version (probably after #7647). @cjnoname, you can try the 1.0.0 version of rspack to identify when it was broken.

Apologies, I haven't had time to test it with version 1.0.1, but I’m quite sure it was working before when I tested it.

cjnoname · 2024-09-17T14:35:17Z

@hardfist

This is a significant issue since Sentry is the primary monitoring tool for many companies, and I hope someone can assist in looking into it.

Verifying the issue is straightforward - a single command line should work:

npx source-map-explorer index.mjs index.mjs.map

github-actions · 2024-09-17T14:54:09Z

Hello @cjnoname, sorry we can't investigate the problem further without reproduction demo, please provide a repro demo by forking rspack-repro, or provide a minimal GitHub repository by yourself. Issues labeled by need reproduction will be closed if no activities in 14 days.

hardfist · 2024-09-17T14:56:30Z

@hardfist

This is a significant issue since Sentry is the primary monitoring tool for many companies, and I hope someone can assist in looking into it.

Verifying the issue is straightforward - a single command line should work:

npx source-map-explorer index.mjs index.mjs.map

@cjnoname I can't investigate more without any reproductions, maybe you should try upgrade to 1.0.5 to see whether the sourcemap problem is solved

cjnoname · 2024-09-17T15:50:43Z

@hardfist
This is a significant issue since Sentry is the primary monitoring tool for many companies, and I hope someone can assist in looking into it.
Verifying the issue is straightforward - a single command line should work:
npx source-map-explorer index.mjs index.mjs.map

@cjnoname I can't investigate more without any reproductions, maybe you should try upgrade to 1.0.5 to see whether the sourcemap problem is solved

https://github.com/cjnoname/rspack-reproduce

You can find the issue with a simple command: "npm run s".

I am not sure if this is the only issue causing the sourcemap to break, or if there might be other issues as well.

yuzhva · 2024-09-17T18:10:12Z

maybe you should try upgrade to 1.0.5 to see whether the sourcemap problem is solved

Hey hi, guys 👋

Would like to confirm that the latest v1.0.5 has a broken source map.

We upgraded from 0.7.5 to 1.0.3 and noticed an issue with the broken source-map - there is a big % of [no source] code based on source-map-explorer package analysis.
(NOTE: you need to run the package with --no-border-checks key to process the broken source maps completely, e.g: npx source-map-explorer --no-border-checks ./dist)

So we downgraded all @rspack packages to stable v1.0.0

hardfist · 2024-09-18T02:32:18Z

@yuzhva @cjnoname sorry for the inconvenience and reproduction, confirmed it's a bug we are gonna fix it ASAP.

cjnoname · 2024-09-18T02:34:49Z

@yuzhva @cjnoname sorry for the inconvenience and reproduction, confirmed it's a bug we are gonna fix it ASAP.

I’ve put together a minimal reproduction repository last night. While I haven't done something exactly like this before, it should accurately represent the issue.

https://github.com/cjnoname/rspack-reproduce

run "npm run s" can present this issue.

Not sure if it's the only issue on sourcemap or not.

SyMind · 2024-09-18T02:47:19Z

I am currently investigating this issue.

SyMind · 2024-09-18T06:07:45Z

@cjnoname Currently, it looks like the issue with the source map is caused by the swc minifier. Please use the Terser Webpack Plugin to handle code minification first.

If the issue persists, there may be other factors causing the source map generation error. Please provide additional repos to reproduce the problem.

SyMind · 2024-09-18T06:09:24Z

In this repository, you can observe that the source maps generated by SWC cause errors in source-map-explorer.
https://github.com/SyMind/swc-minifier-source-map-bug

cjnoname · 2024-09-18T06:13:27Z

In this repository, you can observe that the source maps generated by SWC cause errors in source-map-explorer. https://github.com/SyMind/swc-minifier-source-map-bug

Thank you for investigating this issue. I understand that the SWC minifier is also maintained by your team, correct?

Could you let us know if there are any plans to address this issue in the near future? We are willing to wait a few days if necessary.

We are experiencing poor performance with the Terser Webpack Plugin, which we would prefer not to revert to.

Do you have an estimated timeline for a fix?

Thanks

SyMind · 2024-09-18T07:26:16Z

@cjnoname I'm not certain if the issue is actually caused by the SWC minifier. Could you please try using the Terser Webpack Plugin and see if the problem persists?

SyMind · 2024-09-18T08:15:25Z

@yuzhva Please provide the a demo to reproduce the issue.

cjnoname · 2024-09-18T08:31:45Z

@cjnoname I'm not certain if the issue is actually caused by the SWC minifier. Could you please try using the Terser Webpack Plugin and see if the problem persists?

The issue persists even after I turned off the minimizer and disabled output: module. It still occurs. You can easily check it in my repo by adjusting the rspack.config.js file.

SyMind · 2024-09-18T08:34:56Z

@cjnoname Please don't turn off the minimizer. I've tried this before, and I found that some modules in node_modules have source map comments. This causes source-map-explorer to throw errors.

SyMind · 2024-09-18T08:36:16Z

@cjnoname You can see the code in source-map-explorer here: https://github.com/danvk/source-map-explorer/blob/master/src/lib/explore.ts#L208

cjnoname · 2024-09-18T08:51:19Z

@cjnoname You can see the code in source-map-explorer here: https://github.com/danvk/source-map-explorer/blob/master/src/lib/explore.ts#L208

It works, but it's running much slower than before. Could you help me report this issue to SWC?

SyMind · 2024-09-18T09:03:45Z

@cjnoname Yes. If you can confirm that the issue is caused by the SWC minifier, I will continue to work on it.

SyMind · 2024-10-11T07:01:56Z

@cjnoname I have released the 1.0.10 version https://github.com/web-infra-dev/rspack/releases/tag/v1.0.10

mmazzarolo · 2024-10-11T13:01:52Z

For what's worth, we added @rspack/[email protected] as a resolution (to use it in RSBuild) and production sourcemaps are still broken for us.
Can also pinpoint the issue to be starting from @rspack/[email protected]. If we use @rsbuild/[email protected] (which depends on @rspack/[email protected]) sourcemaps work just fine.

yuzhva · 2024-10-14T11:45:48Z

In 1.0.10 version source maps have been restored for 27.4% for our project - it's still better than having 100% of broken source maps.

It's a bit hard to debug to understand what exactly part of the code does not receive generated source maps: the app code, .mjs modules, or something else 🤷

Will try to debug it more to understand which parts of the source maps are missing...

SyMind · 2024-10-15T02:53:28Z

@mmazzarolo can you give me a reproduce.

mmazzarolo · 2024-10-15T06:46:00Z

I've been trying, but I can't produce a "minimal" reproducible example 😔. Out production codebase is pretty big and as @yuzhva mentioned it's hard to determine what's causing the issue and putting it into a minimal reproducible example. I tried using same RSBuild config and some similar npm packages for example, but with no success.
The only thing I can confirm is that our issues have been introduced in https://github.com/web-infra-dev/rspack/releases/tag/v1.0.1 (I assume it's from #7647) — if we revert to a version of rsbuild that depends on 1.0.0 everything works fine (we're basically stuck in this state since our app is otherwise unusable without working sourcemaps).

SyMind · 2024-10-16T04:30:12Z

I will release a new version for rspack today to fix this issue.

SyMind · 2024-10-16T05:39:27Z

@mmazzarolo I've released a canary version of Rspack @rspack/[email protected]. Could you please verify if it works correctly? Thank you!

To override @rspack/core, use the following configuration:

"@rspack/core": "npm:@rspack/[email protected]"

mmazzarolo · 2024-10-16T07:36:25Z

@SyMind thanks for looking into ti!

I assume you mean to add it as an override/resolution, right?

So adding:

  "resolutions": {
    "@rspack/core": "npm:@rspack/[email protected]"
  },

If I do that, the install step (using pnpm i) goes fine. And I see it resolved correcly in the lockfile.

But building fails:

  Rsbuild v1.0.14

error   Failed to build.
error   Unmatched version @rspack/[email protected], @rspack/[email protected], @rspack/[email protected]
    at checkVersion (/Users/matteo.mazzarolo/workspace/TTVPlatform/node_modules/@rspack/core/dist/index.js:16986:21)
    at #getInstance (/Users/matteo.mazzarolo/workspace/TTVPlatform/node_modules/@rspack/core/dist/index.js:17488:19)
    at #build (/Users/matteo.mazzarolo/workspace/TTVPlatform/node_modules/@rspack/core/dist/index.js:17412:22)
    at /Users/matteo.mazzarolo/workspace/TTVPlatform/node_modules/@rspack/core/dist/index.js:17384:18
    at done (/Users/matteo.mazzarolo/workspace/TTVPlatform/node_modules/@rspack/lite-tapable/dist/index.js:473:13)
    at AsyncSeriesHook.callAsyncStageRange (/Users/matteo.mazzarolo/workspace/TTVPlatform/node_modules/@rspack/lite-tapable/dist/index.js:480:20)
    at AsyncSeriesHook.callAsync (/Users/matteo.mazzarolo/workspace/TTVPlatform/node_modules/@rspack/lite-tapable/dist/index.js:82:21)
    at _Compiler.compile (/Users/matteo.mazzarolo/workspace/TTVPlatform/node_modules/@rspack/core/dist/index.js:17378:30)
    at /Users/matteo.mazzarolo/workspace/TTVPlatform/node_modules/@rspack/core/dist/index.js:17240:16
    at done (/Users/matteo.mazzarolo/workspace/TTVPlatform/node_modules/@rspack/lite-tapable/dist/index.js:473:13)
/Users/matteo.mazzarolo/workspace/TTVPlatform/apps/studio:
 ERR_PNPM_RECURSIVE_RUN_FIRST_FAIL  @synthesia/[email protected] build: `./scripts/build-app-with-rsbuild.sh`
Exit status 1
 ELIFECYCLE  Command failed with exit code 1.

Not sure why. Pinning specific versions of @rspack/core has worked for me before, though. Just not this one.

My setup is the following:

    "@rsbuild/core": "^1.0.14",
    "@rsbuild/plugin-react": "^1.0.4",
    "@rsbuild/plugin-svgr": "^1.0.4",
    "@rsbuild/plugin-type-check": "^1.0.1",
    "@rsdoctor/rspack-plugin": "^0.4.6",

hmdoganjf · 2024-10-16T07:37:46Z

I'm having the same problem with Sentry sourcemaps, and I think this canary build does not work with @rspack/cli. I keep having unmatched version error, and following the dist code I think @rspack/core thinks its on version 1.0.11, while bindings give the canary version.

[rspack-cli] Error: Unmatched version @rspack/[email protected], @rspack/[email protected], @rspack/[email protected]

mmazzarolo · 2024-10-16T11:27:16Z

@SyMind was the fix shipped with @rspack/[email protected]? Asking because i tried forcing it as a resolution to use it with rsbuild and the issue is still there for us.

hmdoganjf · 2024-10-16T11:40:43Z

Can confirm, issue is not resolved on 1.0.12. I guess we will have to wait until the next release.

SyMind · 2024-10-16T12:04:28Z

@mmazzarolo @hmdoganjf I released the v1.0.13 to fix this issue.

hmdoganjf · 2024-10-16T14:36:53Z

Yes! It seems resolved, I can see the sourcemaps on sentry. Thank you for your help.

yuzhva · 2024-10-16T16:33:31Z

In 1.0.10 version source maps have been restored for 27.4% for our project - it's still better than having 100% of broken source maps.

In v1.0.13 source maps are resolved for 77.6%

NOTE: the same amount of source maps was broken in v0.7.5, so it seems to be an old issue, which is not related to the update to v.1

Here are screenshots:

v1.0.10 - 27.2% of source maps are works:

v1.0.13: - 77.6% of source maps are works:

TerserPlugin plugin resolves 100% of source maps:

It seems that:

11.2% of broken source maps are still in node_modules
another 11.2% of broken source maps are still in coudebase

cjnoname · 2024-10-16T20:32:08Z

In 1.0.10 version source maps have been restored for 27.4% for our project - it's still better than having 100% of broken source maps.

In v1.0.13 source maps are resolved for 77.6%

NOTE: the same amount of source maps was broken in v0.7.5, so it seems to be an old issue, which is not related to the update to v.1

Here are screenshots:

v1.0.10 - 27.2% of source maps are works:

v1.0.13: - 77.6% of source maps are works:

TerserPlugin plugin resolves 100% of source maps:

It seems that:

11.2% of broken source maps are still in node_modules

another 11.2% of broken source maps are still in coudebase

How about the RC version mate, was it 100%?

mmazzarolo · 2024-10-17T06:56:09Z

Thanks @SyMind 🙏 This seems to be fixing the issues so far. But we'll need a bit more time to do a complete check.

@cjnoname my understanding from @yuzhva is that the current version (the one with the fix) has a coverage of 77.6% for him. But the coverage with rspack/swc might have never been 100% (even before 1.0.1, which we suspected being the version that introduced the issue).
TerserPlugin does provide a complete coverage though... it would be interesting to understand why we can't do that with rspack/swc.

cjnoname · 2024-10-17T22:46:25Z

Hey guys, I can confirm that the source map is inaccurate, especially as it shows errors on the wrong lines of code.

hardfist · 2024-10-18T02:53:43Z

Thanks @SyMind 🙏 This seems to be fixing the issues so far. But we'll need a bit more time to do a complete check.

@cjnoname my understanding from @yuzhva is that the current version (the one with the fix) has a coverage of 77.6% for him. But the coverage with rspack/swc might have never been 100% (even before 1.0.1, which we suspected being the version that introduced the issue). TerserPlugin does provide a complete coverage though... it would be interesting to understand why we can't do that with rspack/swc.

if terserPlugin provides complete coverage and swc don't provide, then it's normally a swc minifier bug, we may need more information to investigate swc minifier problem

SyMind · 2024-10-18T02:55:49Z

I will continue to make efforts on the SWC minifier, trying to bring it to 100%. However, this process might be quite slow.

yuzhva · 2024-10-18T08:28:01Z

Hey guys, I can confirm that the source map is inaccurate, especially as it shows errors on the wrong lines of code.

@cjnoname we do have the same issue with Terser - errors are shown on the wrong lines of code when Terser is used

SyMind · 2024-10-18T08:55:49Z

@yuzhva can you give me a reproduce repo?

cjnoname added bug Something isn't working pending triage The issue/PR is currently untouched. labels Sep 17, 2024

hardfist added the need reproduction label Sep 17, 2024

hardfist assigned SyMind Sep 18, 2024

hardfist added urgent Fix build-breaking bugs affecting most users, should be released ASAP (priority) and removed need reproduction pending triage The issue/PR is currently untouched. labels Sep 18, 2024

9aoy reopened this Oct 14, 2024

SyMind mentioned this issue Oct 15, 2024

revert: stream_chunks_of_source_map_full web-infra-dev/rspack-sources#120

Merged

SyMind closed this as completed in web-infra-dev/rspack-sources#120 Oct 16, 2024

SyMind reopened this Oct 16, 2024

SyMind mentioned this issue Oct 16, 2024

fix: rspack source for stream_chunks_of_source_map_full #8138

Merged

2 tasks

SyMind closed this as completed in #8138 Oct 16, 2024

hardfist reopened this Oct 16, 2024

SyMind mentioned this issue Oct 18, 2024

fix: source map error with source-map-explorer swc-project/swc#9659

Draft

SyMind mentioned this issue Oct 21, 2024

fix: not generate mappings for runtime code #8176

Closed

2 tasks

[Bug]: The source map is not working on Sentry #7914

[Bug]: The source map is not working on Sentry #7914

Comments

cjnoname commented Sep 17, 2024 • edited Loading

System Info

Details

Reproduce link

Reproduce Steps

hardfist commented Sep 17, 2024

cjnoname commented Sep 17, 2024

cjnoname commented Sep 17, 2024

gitim commented Sep 17, 2024 • edited Loading

cjnoname commented Sep 17, 2024

cjnoname commented Sep 17, 2024

github-actions bot commented Sep 17, 2024

hardfist commented Sep 17, 2024 • edited Loading

cjnoname commented Sep 17, 2024

yuzhva commented Sep 17, 2024 • edited Loading

hardfist commented Sep 18, 2024

cjnoname commented Sep 18, 2024 • edited Loading

SyMind commented Sep 18, 2024

SyMind commented Sep 18, 2024

SyMind commented Sep 18, 2024

cjnoname commented Sep 18, 2024

SyMind commented Sep 18, 2024

SyMind commented Sep 18, 2024

cjnoname commented Sep 18, 2024

SyMind commented Sep 18, 2024

SyMind commented Sep 18, 2024

cjnoname commented Sep 18, 2024

SyMind commented Sep 18, 2024

SyMind commented Oct 11, 2024

mmazzarolo commented Oct 11, 2024 • edited Loading

yuzhva commented Oct 14, 2024 • edited Loading

SyMind commented Oct 15, 2024

mmazzarolo commented Oct 15, 2024

SyMind commented Oct 16, 2024

SyMind commented Oct 16, 2024

mmazzarolo commented Oct 16, 2024 • edited Loading

hmdoganjf commented Oct 16, 2024

mmazzarolo commented Oct 16, 2024 • edited Loading

hmdoganjf commented Oct 16, 2024

SyMind commented Oct 16, 2024

hmdoganjf commented Oct 16, 2024

yuzhva commented Oct 16, 2024 • edited Loading

cjnoname commented Oct 16, 2024

mmazzarolo commented Oct 17, 2024

cjnoname commented Oct 17, 2024

hardfist commented Oct 18, 2024

SyMind commented Oct 18, 2024

yuzhva commented Oct 18, 2024 • edited Loading

SyMind commented Oct 18, 2024

cjnoname commented Sep 17, 2024 •

edited

Loading

gitim commented Sep 17, 2024 •

edited

Loading

hardfist commented Sep 17, 2024 •

edited

Loading

yuzhva commented Sep 17, 2024 •

edited

Loading

cjnoname commented Sep 18, 2024 •

edited

Loading

mmazzarolo commented Oct 11, 2024 •

edited

Loading

yuzhva commented Oct 14, 2024 •

edited

Loading

mmazzarolo commented Oct 16, 2024 •

edited

Loading

mmazzarolo commented Oct 16, 2024 •

edited

Loading

yuzhva commented Oct 16, 2024 •

edited

Loading

yuzhva commented Oct 18, 2024 •

edited

Loading