Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert: stream_chunks_of_source_map_full #120

Merged
merged 4 commits into from
Oct 16, 2024
Merged

revert: stream_chunks_of_source_map_full #120

merged 4 commits into from
Oct 16, 2024

Conversation

SyMind
Copy link
Member

@SyMind SyMind commented Oct 15, 2024 •
edited
Loading

Fix #7914

@SyMind SyMind marked this pull request as ready for review October 15, 2024 07:27
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Oct 16, 2024

CodSpeed Performance Report

Merging #120 will degrade performances by 15.21%

Comparing SyMind:fix-stream_chunks_of_source_map_full (ff2dcd3) with main (fc8af31)

Summary

❌ 1 regressions
✅ 4 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main SyMind:fix-stream_chunks_of_source_map_full Change
❌ replace_large_minified_source 101.5 ms 119.7 ms -15.21%

@SyMind SyMind merged commit 5b438b3 into web-infra-dev:main Oct 16, 2024
6 of 7 checks passed
@SyMind SyMind deleted the fix-stream_chunks_of_source_map_full branch October 16, 2024 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahabhgk ahabhgk ahabhgk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: The source map is not working on Sentry
2 participants
@SyMind @ahabhgk