Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

Upgrade Weave Net to latest version of build-tools, skipping bash scripts when lint-ing. #2749

Merged
merged 3 commits into from
Jan 26, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .lintignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
# IMPORTANT: Please only use GLOBs to ignore files and directories.

# Do not lint any bash script in Weave Net, in order to
# avoid breaking the build on make lint:
*.sh
bin/*
prog/weaveexec/symlink
weave
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ exes $(EXES) tests lint: $(BUILD_UPTODATE)
$(SUDO) docker run $(RM) $(RUN_FLAGS) \
-v $(shell pwd):/go/src/github.com/weaveworks/weave \
-v $(shell pwd)/.pkg:/go/pkg \
-e GOARCH=$(ARCH) -e CGO_ENABLED=1 -e GOOS=linux -e CIRCLECI -e CIRCLE_BUILD_NUM -e CIRCLE_NODE_TOTAL -e CIRCLE_NODE_INDEX -e COVERDIR -e SLOW \
-e GOARCH=$(ARCH) -e CGO_ENABLED=1 -e GOOS=linux -e CIRCLECI -e CIRCLE_BUILD_NUM -e CIRCLE_NODE_TOTAL -e CIRCLE_NODE_INDEX -e COVERDIR -e SLOW -e DEBUG \
$(BUILD_IMAGE) COVERAGE=$(COVERAGE) WEAVE_VERSION=$(WEAVE_VERSION) CC=$(CC) QEMUARCH=$(QEMUARCH) CGO_LDFLAGS=$(CGO_LDFLAGS) $@

else
Expand Down Expand Up @@ -210,7 +210,7 @@ $(SIGPROXY_EXE) $(TEST_TLS_EXE) $(WEAVEWAIT_NOOP_EXE) $(RUNNER_EXE):
go build $(BUILD_FLAGS) -o $@ ./$(@D)

tests:
./tools/test -no-go-get
./tools/test -no-go-get -netgo -timeout 8m

lint:
./tools/lint -nocomment -notestpackage .
Expand Down
2 changes: 1 addition & 1 deletion bin/circle-test-unit
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@ source "$STATE"

if [ -n "$TEST_AND_PUBLISH" ] ; then
cd $SRCDIR
make lint
make DEBUG=1 lint
COVERDIR=test/coverage make RM= tests
fi