This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
Upgrade Weave Net to latest version of build-tools, skipping bash scripts when lint-ing. #2749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marccarre
force-pushed
the
shfmt-ignore
branch
2 times, most recently
from
7365aea to
5481bc7
Compare
marccarre
force-pushed
the
shfmt-ignore
branch
10 times, most recently
from
52c79f0 to
c38b463
Compare
…ipts when lint-ing. Lint-ing all of Weave Net is currently not desirable because: * it would create conflicts on many branches, * it would pollute the git history, * etc. and because `lint` currently lints all files except `./vendor`, this breaks Weave Net's build. As a result, Weave Net is not using the latest commit in `build-tools`'s `master` branch, which is also source of problems: * it limits standardisation of projects across Weaveworks, * it limits the ability to use the latest features of `build-tools`, * it complexifies merging changes in `build-tools` (e.g. #53 and #2694 for #2647), * etc. This change: * brings Weave Net to the latest version of `build-tools` (which now supports `.lintignore` files), * adds such a `.lintignore` file to skip all bash scripts (in order to avoid breaking the build). `GLOB`s in `.lintignore` can then, over time and as scripts are `shfmt`-ed, be relaxed and maybe even removed.
marccarre
force-pushed
the
shfmt-ignore
branch
from
c38b463 to
9432539
Compare
Previous commit upgrades Weave Net to the latest version of `build-tools`. However, `./tools/test`'s default behaviour has changed, so we need to explicitly pass new options/arguments, in order to keep it behaving like before fd56868.
Makes what the build does explicitly and helps for potential debugging. Also reminds us that we are skipping these files, so that we ultimately shfmt them and stop lint-ignoring them.
marccarre
force-pushed
the
shfmt-ignore
branch
from
9432539 to
8e6cb5e
Compare
|
LGTM. |
brb
approved these changes
Jan 26, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lint-ing all of Weave Net is currently not desirable because:
and because
lintcurrently lints all files except./vendor, this breaks Weave Net's build.As a result, Weave Net is not using the latest commit in
build-tools'smasterbranch, which is also source of problems:build-tools,build-tools(e.g. eliminate tx offload disabling in application container #53 and Testing MVP #2694 for Epic - Improve development & testing infrastructure #2647),This change:
build-tools(which now supports.lintignorefiles),.lintignorefile to skip all bash scripts (in order to avoid breaking the build).GLOBs in.lintignorecan then, over time and as scripts areshfmt-ed, be relaxed and maybe even removed.