Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

perf map fixes #37

Merged
merged 2 commits into from
May 10, 2017
Merged

Conversation

alban
Copy link
Contributor

@alban alban commented May 9, 2017

  • vendor fixes from gobpf
  • tcptracer-bpf: change the size of the ring buffer "maps/tcp_event_ipv4" to 256 pages (1MB)
  • tcptracer-bpf: use the go channel to notify lost events

Do we need two different callbacks for IPv4 and IPv6? With the current code, the lostCb could be called from two different go routines in parallel.

Is 1MB a reasonable size for a ring buffer? On my laptop with 4 cpus, that would mean 4MB in total.

Depends on

Useful for weaveworks/scope#2507

@alban alban force-pushed the alban/perf-map-fixes branch from abcf03f to 37465cd Compare May 9, 2017 12:39
@alban alban changed the title [WIP] perf map fixes perf map fixes May 9, 2017
@alban
Copy link
Contributor Author

alban commented May 9, 2017

The build failure comes from build-tools. The fix is available in:
weaveworks/build-tools@e506f1b
I'll update the git-subtree.

@alban alban force-pushed the alban/perf-map-fixes branch from ea3f938 to f638e74 Compare May 10, 2017 16:13
@alban
Copy link
Contributor Author

alban commented May 10, 2017

I re-vendored the last gobpf. shfmt issues should be fixed too.
@2opremio PTAL

@2opremio 2opremio merged commit a82fffd into weaveworks:master May 10, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants