-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ebpf connection tracker: perf map fixes #2507
ebpf connection tracker: perf map fixes #2507
Conversation
Lost events were previously unnoticed. This patch adds an error in the log and stops the ebpf tracker if an event is lost.
86bdeee
to
9079677
Compare
I rebased and revendored gobpf + tcptracer-bpf since PRs have been merged. I'm keeping the "WIP" title because I'd like to test again to make sure nothing was wrong in the rebase/revendor/git-subtrees changes. |
I tried to quickly create plenty of connections to nginx on several cpus with this script (in several terminals):
And I didn't notice any problems in the logs. However, chrome quickly took all the cpu and crashed: |
Mind creating a separate ticket for this? |
(It's not a real scenario, but it's worth keeping track of it) |
|
@2opremio PTAL |
This adds fixes in the perf map that receives the tcp events from the ebpf probes:
This is to address the address the following failure that happened a few weeks ago:
This is a "work in progress" because this is vendoring unmerged branches in gobpf and tcptracer-bpf.
I tried to reduce the size of the perf ring buffers to one page (4KB) in order to test it. I made lots of connections in parallel in 4 terminals (but on the same cpu to stress one perf ring buffer):
Then, I checked that the fallback worked correctly:
/cc @iaguis @2opremio