Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace View Instance with instance dropdown #720

Merged
merged 6 commits into from
Aug 4, 2016
Merged

Conversation

davkal
Copy link

@davkal davkal commented Aug 3, 2016

  • makes it clear what you're viewing
  • allows to quickly change the instance
  • instance management icon was removed, can be reached via dropdown

Fixes #590

davkal added 2 commits August 3, 2016 12:27
* makes it clear what you're viewing
* allows to quickly change the instance
* instance management icon was removed, can be reached via dropdown

Fixes #590
@foot
Copy link
Contributor

foot commented Aug 3, 2016

  • Whaddaya think about getting the cog for the instance away from the profile and over w/ the instance?
  • pointer cursor on the dropdown items would be cool. (is this mobilefirst popping up? why doesn't matui do this, is there a global flag/setting we should be using...) Ayyyyy! https://github.com/callemall/material-ui/blob/v0.15.3/CHANGELOG.md#0153
  • With manage instances losing its prominence, Create new instance is a bit hard to find now, maybe we could put that in the drop down too.
  • Active item in the dropdown diff color/inactive (maybe).

A little related but feels more prominent now

  • Flash of loading when you click the accounts/setting icon, would be nice to hold onto the state across page changes (and perhaps still request and update it if its changed).

@@ -33,6 +33,8 @@ export function getInstance(id) {
if (res.organizations) {
const instance = res.organizations.find(org => org.id === id);
if (instance) {
// hack to only have one request
instance.organizations = res.organizations;

This comment was marked as abuse.

@foot
Copy link
Contributor

foot commented Aug 3, 2016

Code LGTM

@davkal
Copy link
Author

davkal commented Aug 4, 2016

Implemented feedback. Loading instance and identity on page change needs to go in separate PR.

@foot
Copy link
Contributor

foot commented Aug 4, 2016

Nice one! LGTM

@davkal davkal merged commit 987089e into master Aug 4, 2016
@davkal davkal deleted the 590-instance-selector branch August 4, 2016 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants