Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add org.opencontainers.image.* labels to Dockerfiles #2023

Merged
merged 2 commits into from
May 10, 2018

Conversation

marccarre
Copy link

@marccarre marccarre commented May 10, 2018

Why? What?

Testing:

$ docker inspect quay.io/weaveworks/users
[
    {
        [...]
        "ContainerConfig": {
            [...]
            "Labels": {
                "maintainer": "Weaveworks <[email protected]>",
                "org.opencontainers.image.revision": "3df5592",
                "org.opencontainers.image.source": "https://github.com/weaveworks/service/tree/master/users",
                "org.opencontainers.image.title": "users",
                "org.opencontainers.image.vendor": "Weaveworks"
            }
[...]

Related to:

@marccarre marccarre requested review from leth and awh May 10, 2018 15:06
ARG revision
LABEL maintainer="Weaveworks <[email protected]>" \
org.opencontainers.image.title="authfe" \
org.opencontainers.image.source="https://github.com/weaveworks/service/tree/master/authfe" \

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

org.opencontainers.image.source="https://github.com/weaveworks/service/tree/master/billing-aggregator" \
org.opencontainers.image.revision="${revision}" \
org.opencontainers.image.vendor="Weaveworks"

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

marccarre added 2 commits May 10, 2018 16:47
- This should ultimately help for image-to-code back references.
  See also: https://trello.com/c/wJv5EP8b/126-image-to-code-back-references
- `org.label-schema.*` labels are now deprecated, in favour of `org.opencontainers.image.*` labels.
  See also: https://github.com/opencontainers/image-spec/blob/master/annotations.md#back-compatibility-with-label-schema
- `MAINTAINER` is deprecated, in favour of the `maintainer` label.
- `revision` argument will be provided in a subsequent change.
This should ultimately help for image-to-code back references.
See also: https://trello.com/c/wJv5EP8b/126-image-to-code-back-references
@marccarre marccarre force-pushed the add-opencontainers-labels-to-dockerfiles branch from 3df5592 to 5c619d0 Compare May 10, 2018 15:48
@marccarre marccarre merged commit a7be217 into master May 10, 2018
@marccarre marccarre deleted the add-opencontainers-labels-to-dockerfiles branch May 10, 2018 16:23
@marccarre
Copy link
Author

FYI: I'll make similar changes to all other repositories/Dockerfiles soonish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants