-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add org.opencontainers.image.* labels to Dockerfiles #2023
Conversation
ARG revision | ||
LABEL maintainer="Weaveworks <[email protected]>" \ | ||
org.opencontainers.image.title="authfe" \ | ||
org.opencontainers.image.source="https://github.com/weaveworks/service/tree/master/authfe" \ |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
billing-aggregator/Dockerfile
Outdated
org.opencontainers.image.source="https://github.com/weaveworks/service/tree/master/billing-aggregator" \ | ||
org.opencontainers.image.revision="${revision}" \ | ||
org.opencontainers.image.vendor="Weaveworks" | ||
|
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
- This should ultimately help for image-to-code back references. See also: https://trello.com/c/wJv5EP8b/126-image-to-code-back-references - `org.label-schema.*` labels are now deprecated, in favour of `org.opencontainers.image.*` labels. See also: https://github.com/opencontainers/image-spec/blob/master/annotations.md#back-compatibility-with-label-schema - `MAINTAINER` is deprecated, in favour of the `maintainer` label. - `revision` argument will be provided in a subsequent change.
This should ultimately help for image-to-code back references. See also: https://trello.com/c/wJv5EP8b/126-image-to-code-back-references
3df5592
to
5c619d0
Compare
FYI: I'll make similar changes to all other repositories/ |
Why? What?
See also: https://trello.com/c/wJv5EP8b/126-image-to-code-back-references
org.label-schema.*
labels are now deprecated, in favour oforg.opencontainers.image.*
labels.See also: https://github.com/opencontainers/image-spec/blob/master/annotations.md#back-compatibility-with-label-schema
MAINTAINER
is deprecated, in favour of themaintainer
label.git rev-parse --short HEAD
) is now injected atdocker build
time.Testing:
Related to: