Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add org.opencontainers.image.* labels to Dockerfiles #195

Merged
merged 1 commit into from
May 14, 2018

Conversation

marccarre
Copy link
Contributor

Why? What?

Testing:

$ docker inspect quay.io/weaveworks/launcher-agent
[
    {
        [...]
        "ContainerConfig": {
            [...]
            "Labels": {
                "maintainer": "Weaveworks <[email protected]>",
                "org.opencontainers.image.revision": "dbd70c8482ef23d11f434c6b7e7fde9f7c7b3a62",
                "org.opencontainers.image.source": "https://github.com/weaveworks/launcher",
                "org.opencontainers.image.title": "launcher-agent",
                "org.opencontainers.image.vendor": "Weaveworks"
            }
[...]

$ docker inspect quay.io/weaveworks/launcher-service
[
    {
        [...]
        "ContainerConfig": {
            [...]
            "Labels": {
                "maintainer": "Weaveworks <[email protected]>",
                "org.opencontainers.image.revision": "dbd70c8482ef23d11f434c6b7e7fde9f7c7b3a62",
                "org.opencontainers.image.source": "https://github.com/weaveworks/launcher",
                "org.opencontainers.image.title": "launcher-service",
                "org.opencontainers.image.vendor": "Weaveworks"
            }
[...]

- This should ultimately help for image-to-code back references.
- `org.label-schema.*` labels are now deprecated, in favour of `org.opencontainers.image.*` labels.
  See also: https://github.com/opencontainers/image-spec/blob/master/annotations.md#back-compatibility-with-label-schema
- `MAINTAINER` is deprecated, in favour of the `maintainer` label.
- Git revision is now injected at `docker build` time.
@marccarre marccarre merged commit 6813f16 into master May 14, 2018
@marccarre marccarre deleted the add-opencontainers-labels-to-dockerfiles branch May 14, 2018 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants