Fixes process-by-name layout with ./foo and /foo nodes #948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lodash (used by dagre) was in effect mixing up these ids.
|
This is not a super fun PR to review. It introduces another layer of node id munging to fix the Longterm fix would be to try and get something push back into dagre perhaps. |
|
LGTM I guess |
|
Hahah, yes, I think lodash should drop the string version of path. Explicit lists for the win. |
foot
added a commit
that referenced
this pull request
Feb 10, 2016
Fixes process-by-name layout with ./foo and /foo nodes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lodash (used by dagre) was in effect mixing up these ids.
fixes #947