Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty 'processes by name' view #947

Closed
2opremio opened this issue Feb 9, 2016 · 1 comment · Fixed by #948
Closed

Empty 'processes by name' view #947

2opremio opened this issue Feb 9, 2016 · 1 comment · Fixed by #948
Labels
bug Broken end user or developer functionality; not working as the developers intended it component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer
Milestone

Comments

@2opremio
Copy link
Contributor

2opremio commented Feb 9, 2016

My "processes by name" view is empty whilst I don't think it should.

screen shot 2016-02-09 at 10 11 39

Report: https://gist.github.com/2opremio/e6a9751b1bdc7e08e7e0

@2opremio 2opremio added bug Broken end user or developer functionality; not working as the developers intended it component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer labels Feb 9, 2016
@2opremio 2opremio added this to the 0.13.0 milestone Feb 9, 2016
@foot
Copy link
Contributor

foot commented Feb 9, 2016

lodash, the dagre dep [0] is trying to be a bit fancy w/ _.has, it interprets the leading . as a path and fails to initialise its "rank" property (internal to dagre not our rank).

In this dump the conflicting nodes are: ./hyperkube and /hyperkube.

lodash tries to be clever if it thinks the key looks like a path[1]. We can send a PR to dagre, the quick hack would be to make the keys only use \w+. Base64 encode/decode is an option... Having a think about others.

_.has({"/a":1 }, "./a")
true

[0]

"dependencies": {
    "graphlib": "^1.0.5",
    "lodash": "^3.10.0"
}

[1]

var reIsPlainProp = /^\w*$/;

function isKey(value, object) {
  var type = typeof value;
  if ((type == 'string' && reIsPlainProp.test(value)) || type == 'number') {
    return true;
  }
  if (isArray(value)) {
    return false;
  }
  var result = !reIsDeepProp.test(value);
  return result || (object != null && value in toObject(object));
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Broken end user or developer functionality; not working as the developers intended it component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants