Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build inside the build container, using go1.5, by default #583

Closed
wants to merge 4 commits into from

Conversation

tomwilkie
Copy link
Contributor

Fixes #550, fixes #530

And build for GOOS=darwin and GOARCH=arm

With this change, make should build the scope container on a correctly configured Mac, using Docker Machine.

@tomwilkie tomwilkie changed the title Build inside the build container, using go1.5, by default [WIP] Build inside the build container, using go1.5, by default Oct 22, 2015
@tomwilkie tomwilkie self-assigned this Oct 22, 2015
@tomwilkie tomwilkie force-pushed the build-in-container branch 5 times, most recently from a4a02e3 to 5ba40c3 Compare October 22, 2015 12:30
@tomwilkie
Copy link
Contributor Author

Tests temporarily turn off FDP due to weaveworks/weave#1577 (also the reason master is broken)

@tomwilkie tomwilkie changed the title [WIP] Build inside the build container, using go1.5, by default Build inside the build container, using go1.5, by default Oct 22, 2015
@tomwilkie tomwilkie removed their assignment Oct 22, 2015
@peterbourgon
Copy link
Contributor

ugh ~/src/github.com/weaveworks/scope (build-in-container) make
docker run -ti --rm -v /Users/peter/src:/go/src -e GOARCH -e GOOS weaveworks/scope-backend-build /build.bash
Unable to find image 'weaveworks/scope-backend-build:latest' locally
Pulling repository docker.io/weaveworks/scope-backend-build
Error: image weaveworks/scope-backend-build:latest not found
make: *** [backend] Error 1

Update: make clean isn't removing the .uptodate files...

@tomwilkie
Copy link
Contributor Author

Ah good catch. Thanks, will fix.

@tomwilkie
Copy link
Contributor Author

@peterbourgon PTAL

@tomwilkie
Copy link
Contributor Author

@paulbellamy we've also switched out the ca-certificates for https://github.com/certifi/gocertifi as building on a Mac was giving this error:

make: *** No rule to make target `/etc/ssl/certs/ca-certificates.crt', needed by `docker/ca-certificates.crt'.  Stop.

Would you mind giving that a review?

@peterbourgon
Copy link
Contributor

Currently broken due to that k8s import problem so my testing ability is compromised but LGTM.

@tomwilkie
Copy link
Contributor Author

Thanks @peterbourgon; if you test #584 that includes all the changes from this PR and shouldn't build fine.

@tomwilkie
Copy link
Contributor Author

Actually going to close this in favour of #584

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants