-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build inside the build container, using go1.5, by default #583
Conversation
a4a02e3
to
5ba40c3
Compare
Tests temporarily turn off FDP due to weaveworks/weave#1577 (also the reason master is broken) |
Update: |
Ah good catch. Thanks, will fix. |
@peterbourgon PTAL |
@paulbellamy we've also switched out the ca-certificates for https://github.com/certifi/gocertifi as building on a Mac was giving this error:
Would you mind giving that a review? |
ddba16d
to
a48b6d4
Compare
Currently broken due to that k8s import problem so my testing ability is compromised but LGTM. |
Thanks @peterbourgon; if you test #584 that includes all the changes from this PR and shouldn't build fine. |
Actually going to close this in favour of #584 |
Fixes #550, fixes #530
And build for GOOS=darwin and GOARCH=arm
With this change,
make
should build the scope container on a correctly configured Mac, using Docker Machine.