Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move entirely to Go 1.5, remove netgo cruft from Makefile #530

Closed
peterbourgon opened this issue Sep 30, 2015 · 2 comments
Closed

Move entirely to Go 1.5, remove netgo cruft from Makefile #530

peterbourgon opened this issue Sep 30, 2015 · 2 comments
Assignees
@tomwilkie
Labels
tech-debt Unpleasantness that does (or may in future) affect development

Comments

@peterbourgon
Copy link
Contributor

  • Check for Go 1.5 during builds
  • Remove all netgo cruft from Makefile and other scripts
@peterbourgon peterbourgon added the tech-debt Unpleasantness that does (or may in future) affect development label Sep 30, 2015
@tomwilkie
Copy link
Contributor

Alternatively, how about we move to a completely container-based build process (we almost have it), have that container use go1.5?

Also, its not clear we can remove the netgo cruft, given what we discovered when deploying the service.

@peterbourgon
Copy link
Contributor Author

+1 to both points. Please amend the original post?

@tomwilkie tomwilkie mentioned this issue Oct 22, 2015
Closed
@tomwilkie tomwilkie self-assigned this Oct 22, 2015
@tomwilkie tomwilkie mentioned this issue Oct 26, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomwilkie tomwilkie

Labels
tech-debt Unpleasantness that does (or may in future) affect development
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Build inside the build container, using go1.5, by default weaveworks/scope
2 participants
@peterbourgon @tomwilkie